You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "Bill (GitHub)" <gi...@apache.org> on 2020/03/24 16:28:03 UTC

[GitHub] [geode] Bill commented on pull request #4843: GEODE-7900: Only set the SNI hostname if it is not present

Two things:

1. a nit: the allocation can be moved after the conditional :)
2. is the type check sufficient or is a content check necessary?

on (2) I wonder if there is a scenario where SNI might be set already, but maybe it _disagrees_ with `addr.getHostName()`

[ Full content available at: https://github.com/apache/geode/pull/4843 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org