You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "youngkermit8-coder (via GitHub)" <gi...@apache.org> on 2026/08/11 12:09:05 UTC

[PR] [Studio][ISSUE #1752] Reject blank ACL usernames on update [rocketmq-dashboard]

youngkermit8-coder opened a new pull request, #1753:
URL: https://github.com/apache/rocketmq-dashboard/pull/1753

   ## Summary
   
   - reject a supplied blank or whitespace-only ACL username during partial user updates
   - preserve the existing username when the update omits the field
   - add a regression test that verifies the invalid update returns 400 without saving
   
   ## Root cause and impact
   
   `AclService.createUser` already rejects blank usernames, but `updateUser` only distinguished null from non-null. As a result, whitespace could replace a valid stored username and leave invalid ACL account data behind.
   
   The update path now applies the same `StringUtils.hasText` rule when the optional field is present. Null continues to mean that the existing username is preserved.
   
   Fixes #1752.
   
   ## Validation
   
   - Reproduced on the current `rocketmq-studio` branch with the focused regression (failed because no exception was raised and the repository was written)
   - `mvn -B -ntp -Dtest=AclServiceTest,AclControllerTest,AclUserVOTest,IpRangeMatcherTest,MybatisPlusAclRepositoryTest test` — 83 tests passed
   - Maven Checkstyle — 0 violations
   - `mvn -B -ntp -DskipTests package` — passed
   - `git diff --check` — passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio][ISSUE #1752] Reject blank ACL usernames on update [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1753: [Studio][ISSUE #1752] Reject blank ACL usernames on update
URL: https://github.com/apache/rocketmq-dashboard/pull/1753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio][ISSUE #1752] Reject blank ACL usernames on update [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1753:
URL: https://github.com/apache/rocketmq-dashboard/pull/1753#issuecomment-5280010160

   Consolidated into #2046 as part of the batch consolidation of @youngkermit8-coder's ACL/permission PRs (merged into rocketmq-studio). The change is preserved in the merged commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org