[GitHub] [arrow] jorisvandenbossche commented on pull request #14395: ARROW-17960: [C++][Python] Implement list_slice kernel

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on PR #14395:
URL: https://github.com/apache/arrow/pull/14395#issuecomment-1302538819

   @lidavidm thanks a lot for the review! Do you have an opinion on some of the API questions raised at https://github.com/apache/arrow/pull/14395#issuecomment-1293369447 ? (and Miles' answer just below) 
   I am still feeling unsure about the `return_fixed_size_list` keyword and its default. Especially if we would support "slicing until the end" (i.e. without specifying a `stop`), it feels strange that the default would then check for the longest list and pad all others (to produce a fixed size list). 
   
   Another default could be to always preserve the original type by default (so fixed size -> fixed size, variable size -> variable size), with still an option to choose explicitly. But then we need to make that keyword optional as well, since the default value would depend on the input type. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org