You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hiSandog (via GitHub)" <gi...@apache.org> on 2026/08/25 07:48:31 UTC

[PR] [Fix][Common] Mask credentials with quoted keys [seatunnel]

hiSandog opened a new pull request, #11959:
URL: https://github.com/apache/seatunnel/pull/11959

   ### Purpose of this pull request
   
   Prevent credentials from appearing in connect dry-run failure messages when sensitive configuration keys are quoted, for example `"password": "secret"` or `'api_key': 'secret'`. The sanitizer now recognizes optional quotes around sensitive keys and keeps masking their values. A regression test covers JSON- and HOCON-style input.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Dry-run CLI failure messages now replace values associated with quoted sensitive keys with `***`, matching the existing behavior for unquoted keys.
   
   ### How was this patch tested?
   
   - `./mvnw spotless:apply`
   - `./mvnw -pl seatunnel-common -am -Dskip.spotless=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=DryRunConnectFailureMessageSanitizerTest package`
   - `./mvnw -q -DskipTests verify`
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] Documentation is not necessary for this masking fix.
   * [x] This PR introduces no incompatible change.
   * [x] This PR does not modify connector code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Common] Mask credentials with quoted keys [seatunnel]

Posted by "hiSandog (via GitHub)" <gi...@apache.org>.
hiSandog closed pull request #11959: [Fix][Common] Mask credentials with quoted keys
URL: https://github.com/apache/seatunnel/pull/11959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Common] Mask credentials with quoted keys [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11959:
URL: https://github.com/apache/seatunnel/pull/11959#issuecomment-5423995811

   Thanks @davidzollo for the +1!
   
   I dug into the current `Build` failure at head `45aa3de8` to confirm it's not related to this diff. The fork run (https://github.com/hiSandog/seatunnel/actions/runs/32823305965) has exactly three non-infra-skip failing jobs: `kudu-connector-it (8, ubuntu-latest)`, `all-connectors-it-2 (8, ubuntu-latest)`, and `rocketmq-connector-it (11, ubuntu-latest)`.
   
   I checked the `kudu-connector-it` log directly — it fails before any test code runs, at the Maven Wrapper download step:
   
   ```
   HTTP request sent, awaiting response... 429 Too Many Requests
   Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
   ```
   
   That's a `repo.maven.apache.org` rate-limit hit during `./mvnw` bootstrap, nothing to do with the Kudu/RocketMQ connector modules or with `seatunnel-common`'s `DryRunConnectFailureMessageSanitizer` that this PR touches. So this looks like a transient CI infra flake rather than a real regression from this change.
   
   @hiSandog since there's no new commit needed here, could you push an empty commit or ask a maintainer to re-run the failed jobs (`kudu-connector-it`, `all-connectors-it-2`, `rocketmq-connector-it`) on the fork? Once those come back green this should be ready to merge per davidzollo's conditional +1.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org