[GitHub] [tvm] Mousius commented on a change in pull request #9397: [CMSIS-NN] Convert CMSIS-NN to use Target Hooks

[GitBox <gi...@apache.org>]

Mousius commented on a change in pull request #9397:
URL: https://github.com/apache/tvm/pull/9397#discussion_r740266306



##########
File path: src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc
##########
@@ -25,114 +25,50 @@
 
 #include "../../../../runtime/file_utils.h"
 #include "../../../../target/source/codegen_c.h"
+#include "../../../../target/source/codegen_c_host.h"
 
 namespace tvm {
-namespace codegen {
-
 using namespace tir;
+namespace relay {
+namespace contrib {
+namespace cmsisnn {
 
-class CodeGenCMSISNN : public CodeGenC {
+class CodeGenCMSISNN : public codegen::CodeGenCHost {

Review comment:
       In other `Target`s they get PrimFunc's which are essentially:
   ```
   { [Host Module] -> [Device Lib Module] } -> [Device]
   ```
   So conceptually it makes sense to do:
   ```
   { [Host Module] } -> [Lib]
   ```
   For CMSIS-NN and other library targets, as TVM is hosting the library - I think, would be interested in @manupa-arm's view here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org