You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/10/19 08:04:27 UTC
[jira] Created: (CASSANDRA-1629) disallow memtable sizes <= 0
disallow memtable sizes <= 0
----------------------------
Key: CASSANDRA-1629
URL: https://issues.apache.org/jira/browse/CASSANDRA-1629
Project: Cassandra
Issue Type: Bug
Reporter: Brandon Williams
Priority: Minor
Fix For: 0.7.0
It's possible to create memtable size thresholds <= 0 currently. If your thrift interface is old, this is easy to do accidentally, and we shouldn't allow this in general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1629) disallow memtable sizes <= 0
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922641#action_12922641 ]
Brandon Williams commented on CASSANDRA-1629:
---------------------------------------------
Close inspection shows the code already won't allow anything to be <= 0. I'm not sure how you were able to do this, can you provide the steps you went through Paul?
> disallow memtable sizes <= 0
> ----------------------------
>
> Key: CASSANDRA-1629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1629
> Project: Cassandra
> Issue Type: Bug
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> It's possible to create memtable size thresholds <= 0 currently. If your thrift interface is old, this is easy to do accidentally, and we shouldn't allow this in general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1629) disallow memtable sizes <= 0
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1629.
---------------------------------------
Resolution: Cannot Reproduce
> disallow memtable sizes <= 0
> ----------------------------
>
> Key: CASSANDRA-1629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1629
> Project: Cassandra
> Issue Type: Bug
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> It's possible to create memtable size thresholds <= 0 currently. If your thrift interface is old, this is easy to do accidentally, and we shouldn't allow this in general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1629) disallow memtable sizes <= 0
Posted by "Paul Bohm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924227#action_12924227 ]
Paul Bohm commented on CASSANDRA-1629:
--------------------------------------
i was one thrift version behind when they were introduced. (e.g. my thrift wrappers didn't know about them)
then i used describe to get the CfDef, edited something in it, and updated the CfDef.
either the cassandra version upgrade or the describe->update(without correct thrift bindings) must have caused it
hopefully not going to happen for non-trunk upgrades
> disallow memtable sizes <= 0
> ----------------------------
>
> Key: CASSANDRA-1629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1629
> Project: Cassandra
> Issue Type: Bug
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> It's possible to create memtable size thresholds <= 0 currently. If your thrift interface is old, this is easy to do accidentally, and we shouldn't allow this in general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1629) disallow memtable sizes <= 0
Posted by "Paul Bohm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922466#action_12922466 ]
Paul Bohm commented on CASSANDRA-1629:
--------------------------------------
Table.java:~275 in trunk
flushTask = StorageService.scheduledTasks.scheduleWithFixedDelay(runnable, minCheckMs, minCheckMs, TimeUnit.MILLISECONDS);
crashes cassandra when minCheckMs == 0, as can result from e.g. memtableFlushAfterMins == 0.
There's no easy way for users to recover from this. Probably both setting the memtable thresholds and above should have sanity checks.
> disallow memtable sizes <= 0
> ----------------------------
>
> Key: CASSANDRA-1629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1629
> Project: Cassandra
> Issue Type: Bug
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> It's possible to create memtable size thresholds <= 0 currently. If your thrift interface is old, this is easy to do accidentally, and we shouldn't allow this in general.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.