[GitHub] [superset] riahk commented on a change in pull request #12311: fix(alert/report): add/edit modal can't be saved

[GitBox <gi...@apache.org>]

riahk commented on a change in pull request #12311:
URL: https://github.com/apache/superset/pull/12311#discussion_r553026326



##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -540,12 +540,14 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
     fetchResource,
     createResource,
     updateResource,
+    clearError,
   } = useSingleViewResource<AlertObject>('report', t('report'), addDangerToast);
 
   // Functions
   const hide = () => {
     setIsHidden(true);
     onHide();
+    clearError();

Review comment:
       slight nit but let's do this before `onHide`, so we complete all internal logic before external logic




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org