You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/06/23 08:21:11 UTC

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2039: [bugfix][api-draft] Fix KafkaSource parallel mode failure

Hisoka-X commented on code in PR #2039:
URL: https://github.com/apache/incubator-seatunnel/pull/2039#discussion_r904717206


##########
seatunnel-connectors/seatunnel-connectors-seatunnel/seatunnel-connector-seatunnel-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -147,10 +147,10 @@ private Set<KafkaSourceSplit> getTopicInfo() throws ExecutionException, Interrup
 
     private void assignSplit(Collection<Integer> taskIDList) {

Review Comment:
   This method assginSplit to task which in parameter. If change like you code, the parameter should be remove because it's not used. But this method will assginSplit to all task every time, it's ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org