[GitHub] [iceberg] szehon-ho commented on a change in pull request #3199: Core: Validate concurrently added delete files in OvewriteFiles

[GitBox <gi...@apache.org>]

szehon-ho commented on a change in pull request #3199:
URL: https://github.com/apache/iceberg/pull/3199#discussion_r718924611



##########
File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java
##########
@@ -145,4 +151,50 @@
    */
   @Deprecated
   OverwriteFiles validateNoConflictingAppends(Long readSnapshotId, Expression conflictDetectionFilter);
+
+  /**
+   * Sets a conflict detection filter used to validate concurrently added data and delete files.

Review comment:
       Am I right to understand that we use rowFilter to do the detection, if this is not set?  Should we mention it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org