You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2023/03/07 15:10:50 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #29956: Fix some new graph bugs
bbovenzi opened a new pull request, #29956:
URL: https://github.com/apache/airflow/pull/29956
1. Edges between two different join nodes we're being positioned incorrectly. Edges inside of groups are positioned relative to the group as a whole, but between groups are positioned absolutely.
2. Wrap task group text to prevent overflow.
3. Highlight all edges related to a task group when a group is selected
| Before | After |
| ------------- | ------------- |
| <img width="285" alt="Screenshot 2023-03-02 at 3 51 58 PM" src="https://user-images.githubusercontent.com/4600967/223462095-f2bdebdc-0105-40b5-8632-1632ae29a01e.png"> | <img width="365" alt="Screenshot 2023-03-02 at 3 52 05 PM" src="https://user-images.githubusercontent.com/4600967/223462131-a8e0b616-f964-4e5c-a123-9f78bc9adf06.png"> |
| <img width="869" alt="Screenshot 2023-03-07 at 10 09 50 AM" src="https://user-images.githubusercontent.com/4600967/223463160-a9f4dd95-3d35-41b7-8cf2-0b528c3237ae.png"> | <img width="995" alt="Screenshot 2023-03-07 at 10 09 33 AM" src="https://user-images.githubusercontent.com/4600967/223463200-012ebe13-5744-45d5-9ef2-46d2d8c7c576.png"> |
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #29956: Fix some new graph bugs
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #29956:
URL: https://github.com/apache/airflow/pull/29956#discussion_r1131230857
##########
airflow/www/static/js/dag/details/graph/utils.ts:
##########
@@ -151,15 +151,24 @@ export const buildEdges = ({
const targetIds = e.target.split(".");
const isSelected =
selectedTaskId &&
- (e.source === selectedTaskId || e.target === selectedTaskId);
+ (e.source.includes(selectedTaskId) ||
+ e.target.includes(selectedTaskId));
if (
sourceIds.length === targetIds.length &&
sourceIds[0] === targetIds[0]
) {
- const parentIds =
+ let parentIds =
sourceIds.length > targetIds.length ? sourceIds : targetIds;
- parentIds.pop();
+
+ if (e.target.includes("_join_id") && e.source.includes("_join_id")) {
Review Comment:
```suggestion
if (e.target.endsWith("_join_id") && e.source.endsWith("_join_id")) {
```
I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29956: Fix some new graph bugs
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29956:
URL: https://github.com/apache/airflow/pull/29956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org