Re: [PATCH] Issue 1846, RA layer part, take 2

["Peter N. Lundblad" <pe...@famlundblad.se>]

Hi,

I've implemented the suggestions from ghudson and sussman. Here is
hopefully the last version of this patch before commit.

I've tested (on my machine!!!) all three RA implementations against a
trunk server and the two network layers against 1.0. On 1.0 I got a
failure that has nothing to do with this patch AFAIK. So I think it works
pretty well now.

Comments?

Regards,
//Peter

Re: [PATCH] Issue 1846, RA layer part, take 2

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Fri, 18 Jun 2004, Greg Hudson wrote:

> Okay, first, those blank lines aren't really doing anything except
> visually separating the /* Read the hash items. */ comment from the code
> it's talking about.  Second, the ### comment should go, if it's talking
> about what I think it's talking about.  If the server encounters an
> error, it will write out "done" and then send an error in the command
> response.
>
Huh, in 10048...

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Issue 1846, RA layer part, take 2

[Greg Hudson <gh...@MIT.EDU>]

+  /* Read the hash items. */
+  is_done = FALSE;
+
+  *locations = apr_hash_make(pool);
+
+  /* ### Check for error and return not implemented. */
+  while (!is_done)

Okay, first, those blank lines aren't really doing anything except
visually separating the /* Read the hash items. */ comment from the code
it's talking about.  Second, the ### comment should go, if it's talking
about what I think it's talking about.  If the server encounters an
error, it will write out "done" and then send an error in the command
response.

Otherwise, everything but the DAV part looks okay to me.  Fortunately,
the above is just a cosmetic change, so it shouldn't require another
iteration of testing.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org