You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2016/07/19 12:20:03 UTC

Re: Review Request 47021: FLUME-2908: NetcatSource - SocketChannel not closed when session is broken

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47021/#review142739
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Alten-Lorenz


On May 5, 2016, 4:05 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47021/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 4:05 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2908
>     https://issues.apache.org/jira/browse/FLUME-2908
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> When the NetcatSource socketChannel receives an IOException due to an abruptly closed session the exception is caught but the socketChannel is never closed. This results in leaked sockets and ever growing file descriptors.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 61e3f90c014fc5cded2f2e997144c64bfe6f8e17 
> 
> Diff: https://reviews.apache.org/r/47021/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>