[GitHub] [hbase] wchevreuil commented on a change in pull request #2179: HBASE-24694 Support flush a single column family of table

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2179:
URL: https://github.com/apache/hbase/pull/2179#discussion_r465735191



##########
File path: hbase-shell/src/main/ruby/shell/commands/flush.rb
##########
@@ -25,10 +25,11 @@ def help
 Flush all regions in passed table or pass a region row to
 flush an individual region or a region server name whose format
 is 'host,port,startcode', to flush all its regions.
-You can also flush a single column family within a region.
+You can also flush a single column family within a table or region.

Review comment:
       `You can also flush a single column family for all regions within a table, or for an specific region only.`

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##########
@@ -302,6 +302,13 @@
    */
   CompletableFuture<Void> flush(TableName tableName);
 
+  /**
+   * Flush a table with specified column family.

Review comment:
       Similar to above.

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -513,6 +513,15 @@ default void modifyColumnFamily(TableName tableName, ColumnFamilyDescriptor colu
    */
   void flush(TableName tableName) throws IOException;
 
+  /**
+   * Flush a table with specified column family. Synchronous operation.

Review comment:
       Let's not leave any room for confusion: `Flush the specified column family stores on all regions of the passed table. This runs as a synchronous operation.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org