You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Lewuathe <gi...@git.apache.org> on 2014/11/19 23:09:53 UTC
[GitHub] storm pull request: Typo in storm-kafka README
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/320
Typo in storm-kafka README
Fix typos in storm-kafka README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lewuathe/storm typo-format-storm-kafka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #320
----
commit d9dc3b2a173b0124986767ff3f63b72284958467
Author: lewuathe <le...@me.com>
Date: 2014-11-19T22:06:49Z
Typo in storm-kafka README
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/320#issuecomment-64961892
+1 - this is small enough I am happy to check this in without a JIRA. @Lewuathe in the future feel free to file a JIRA at http://issues.apache.org/jira/ It is not required for small changes like this, but it make tracking changes to the code base simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/320#issuecomment-64717628
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by Lewuathe <gi...@git.apache.org>.
Github user Lewuathe commented on the pull request:
https://github.com/apache/storm/pull/320#issuecomment-64972683
@revans2 Thank you your advice. I filed ticket about this PR, but I forgot prepend ticket number. Sorry for your inconvenience.
https://issues.apache.org/jira/browse/STORM-574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/320#issuecomment-64491486
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Typo in storm-kafka README
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/320#issuecomment-160042694
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---