You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "duongkame (via GitHub)" <gi...@apache.org> on 2023/04/21 21:54:36 UTC
[GitHub] [ozone] duongkame opened a new pull request, #4609: HDDS-8475. Unexpected IOException should be returned as INTERNAL_ERROR.
duongkame opened a new pull request, #4609:
URL: https://github.com/apache/ozone/pull/4609
## What changes were proposed in this pull request?
Unexpected IOException is returned as KEY_NOT_FOUND and the original error is swallowed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8475
## How was this patch tested?
Standard CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4609: HDDS-8475. Unexpected IOException should be returned as INTERNAL_ERROR.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4609:
URL: https://github.com/apache/ozone/pull/4609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4609: HDDS-8475. Unexpected IOException should be returned as INTERNAL_ERROR.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4609:
URL: https://github.com/apache/ozone/pull/4609#issuecomment-1522988904
Thanks @duongkame for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4609: HDDS-8475. Unexpected IOException should be returned as INTERNAL_ERROR.
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4609:
URL: https://github.com/apache/ozone/pull/4609#discussion_r1175068566
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -413,11 +413,8 @@ private OmKeyInfo readKeyInfo(OmKeyArgs args) throws IOException {
if (ex instanceof OMException) {
throw ex;
}
- if (LOG.isDebugEnabled()) {
- LOG.debug("Get key failed for volume:{} bucket:{} key:{}", volumeName,
- bucketName, keyName, ex);
- }
- throw new OMException(ex.getMessage(), KEY_NOT_FOUND);
+ throw new OMException("Error reading key metadata: " + keyName, ex,
Review Comment:
Should the message include volume and bucket name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org