You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Kontinuation (via GitHub)" <gi...@apache.org> on 2025/06/04 15:47:06 UTC
[PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Kontinuation opened a new pull request, #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845
## Which issue does this PR close?
Closes #1844 and probably #1823.
## Rationale for this change
Loading data with custom schema may produce rows containing null struct fields. Shuffling such null struct fields throws exceptions mentioned in the linked issues.
## What changes are included in this PR?
Fixes appending null rows to `StructBuilder` by making children field builders always in sync with the parent struct builder.
## How are these changes tested?
1. Add unit tests for `append_field` in native code
2. Add a Scala unit test modified from the minimal repro of the bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845#discussion_r2126985383
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -3319,6 +3319,7 @@ mod test {
}
#[test]
+ #[cfg_attr(miri, ignore)] // Unaligned memory access in SparkUnsafeRow
Review Comment:
Do we want to file a follow-on issue to remove the unaligned memory access?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845#issuecomment-2941046157
I confirmed that this does also close https://github.com/apache/datafusion-comet/issues/1823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845#issuecomment-2940607579
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1845?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 32.20%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8dc4e9b`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/8dc4e9b595d4c6b77b1cf6125629e6e557a0e2bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 240 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1845 +/- ##
=============================================
- Coverage 56.12% 32.20% -23.92%
+ Complexity 976 651 -325
=============================================
Files 119 130 +11
Lines 11743 12655 +912
Branches 2251 2357 +106
=============================================
- Hits 6591 4076 -2515
- Misses 4012 7787 +3775
+ Partials 1140 792 -348
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1845?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix shuffle writing rows containing null struct fields [datafusion-comet]
Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on code in PR #1845:
URL: https://github.com/apache/datafusion-comet/pull/1845#discussion_r2127825909
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -3319,6 +3319,7 @@ mod test {
}
#[test]
+ #[cfg_attr(miri, ignore)] // Unaligned memory access in SparkUnsafeRow
Review Comment:
Logged https://github.com/apache/datafusion-comet/issues/1849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org