You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/07/20 09:47:11 UTC

[GitHub] flink pull request #4378: [FLINK-7233][tests] fix instable TaskManagerHeapSi...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4378

    [FLINK-7233][tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest

    This fixes `getRandomConfig()` being prone to integer overflows and creating
    invalid configuration values.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4378
    
----
commit d0a5e3116b4aefc10603a43d077583e2f7cd99de
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-20T09:44:08Z

    [FLINK-7233][tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest
    
    This fixes getRandomConfig() being prone to integer overflows and creating
    invalid configuration values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4378: [FLINK-7233][tests] fix instable TaskManagerHeapSi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4378


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4378: [FLINK-7233][tests] fix instable TaskManagerHeapSizeCalcu...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4378
  
    Good fix!
    
    Merging to `master` and `release-1.3`...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---