You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/07/03 07:53:08 UTC

[shardingsphere-elasticjob-lite] branch master updated: fix member variable access modifiers. (#915)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob-lite.git


The following commit(s) were added to refs/heads/master by this push:
     new 3113b19  fix member variable access modifiers. (#915)
3113b19 is described below

commit 3113b1929faa69f2ee101b935f9dd274f97879b4
Author: keker <as...@163.com>
AuthorDate: Fri Jul 3 15:53:03 2020 +0800

    fix member variable access modifiers. (#915)
    
    * fix method if return void, web page is not refresh.
    
    * fix member variable access modifiers.
---
 .../elasticjob/lite/executor/ElasticJobExecutor.java       |  1 -
 .../elasticjob/lite/internal/election/LeaderNode.java      |  2 +-
 .../elasticjob/lite/internal/failover/FailoverNode.java    |  8 ++++----
 .../elasticjob/lite/internal/guarantee/GuaranteeNode.java  |  2 +-
 .../elasticjob/lite/internal/sharding/ShardingNode.java    | 14 +++++++-------
 5 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/executor/ElasticJobExecutor.java b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/executor/ElasticJobExecutor.java
index d9c1c97..53826e6 100644
--- a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/executor/ElasticJobExecutor.java
+++ b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/executor/ElasticJobExecutor.java
@@ -79,7 +79,6 @@ public final class ElasticJobExecutor {
         itemErrorMessages = new ConcurrentHashMap<>(jobConfig.getShardingTotalCount(), 1);
     }
     
-    @SuppressWarnings("unchecked")
     private static JobItemExecutor getJobItemExecutor(final ElasticJob elasticJob) {
         if (elasticJob instanceof SimpleJob) {
             return new SimpleJobExecutor();
diff --git a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/election/LeaderNode.java b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/election/LeaderNode.java
index 1f3cca3..b77b8f4 100644
--- a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/election/LeaderNode.java
+++ b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/election/LeaderNode.java
@@ -26,7 +26,7 @@ public final class LeaderNode {
     
     public static final String ROOT = "leader";
     
-    static final String ELECTION_ROOT = ROOT + "/election";
+    private static final String ELECTION_ROOT = ROOT + "/election";
     
     static final String INSTANCE = ELECTION_ROOT + "/instance";
     
diff --git a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/failover/FailoverNode.java b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/failover/FailoverNode.java
index b403b09..734faf7 100644
--- a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/failover/FailoverNode.java
+++ b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/failover/FailoverNode.java
@@ -26,13 +26,13 @@ import org.apache.shardingsphere.elasticjob.lite.internal.storage.JobNodePath;
  */
 public final class FailoverNode {
     
-    static final String FAILOVER = "failover";
+    private static final String FAILOVER = "failover";
     
-    static final String LEADER_ROOT = LeaderNode.ROOT + "/" + FAILOVER;
+    private static final String LEADER_ROOT = LeaderNode.ROOT + "/" + FAILOVER;
     
     static final String ITEMS_ROOT = LEADER_ROOT + "/items";
     
-    static final String ITEMS = ITEMS_ROOT + "/%s";
+    private static final String ITEMS = ITEMS_ROOT + "/%s";
     
     static final String LATCH = LEADER_ROOT + "/latch";
     
@@ -54,7 +54,7 @@ public final class FailoverNode {
     
     /**
      * Get sharding item by execution failover path.
-     * 
+     *
      * @param path failover path
      * @return sharding item, return null if not from failover path
      */
diff --git a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/guarantee/GuaranteeNode.java b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/guarantee/GuaranteeNode.java
index 454a086..249b9a4 100644
--- a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/guarantee/GuaranteeNode.java
+++ b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/guarantee/GuaranteeNode.java
@@ -25,7 +25,7 @@ import com.google.common.base.Joiner;
  */
 public final class GuaranteeNode {
     
-    static final String ROOT = "guarantee";
+    private static final String ROOT = "guarantee";
     
     static final String STARTED_ROOT = ROOT + "/started";
     
diff --git a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/sharding/ShardingNode.java b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/sharding/ShardingNode.java
index 6322f78..27a29da 100644
--- a/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/sharding/ShardingNode.java
+++ b/elastic-job-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/sharding/ShardingNode.java
@@ -27,19 +27,19 @@ public final class ShardingNode {
     
     public static final String ROOT = "sharding";
     
-    static final String INSTANCE_APPENDIX = "instance";
+    private static final String INSTANCE_APPENDIX = "instance";
     
-    public static final String INSTANCE = ROOT + "/%s/" + INSTANCE_APPENDIX;
+    private static final String INSTANCE = ROOT + "/%s/" + INSTANCE_APPENDIX;
     
-    static final String RUNNING_APPENDIX = "running";
+    private static final String RUNNING_APPENDIX = "running";
     
-    static final String RUNNING = ROOT + "/%s/" + RUNNING_APPENDIX;
+    private static final String RUNNING = ROOT + "/%s/" + RUNNING_APPENDIX;
     
-    static final String MISFIRE = ROOT + "/%s/misfire";
+    private static final String MISFIRE = ROOT + "/%s/misfire";
     
-    static final String DISABLED = ROOT + "/%s/disabled";
+    private static final String DISABLED = ROOT + "/%s/disabled";
     
-    static final String LEADER_ROOT = LeaderNode.ROOT + "/" + ROOT;
+    private static final String LEADER_ROOT = LeaderNode.ROOT + "/" + ROOT;
     
     static final String NECESSARY = LEADER_ROOT + "/necessary";