[GitHub] [incubator-shenyu] haibo-duan commented on a change in pull request #2841: [ISSUE 2830] Update junit4 to junit5 - update for common module

[GitBox <gi...@apache.org>]

haibo-duan commented on a change in pull request #2841:
URL: https://github.com/apache/incubator-shenyu/pull/2841#discussion_r802226521



##########
File path: shenyu-common/src/test/java/org/apache/shenyu/common/enums/WafEnumTest.java
##########
@@ -17,9 +17,9 @@
 
 package org.apache.shenyu.common.enums;
 
-import static org.junit.Assert.assertEquals;
+import org.junit.jupiter.api.Test;
 
-import org.junit.Test;
+import static org.junit.Assert.assertEquals;

Review comment:
       please use org.junit.jupiter.api.Assertions.assertEquals

##########
File path: shenyu-common/pom.xml
##########
@@ -63,6 +63,13 @@
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-collections4</artifactId>
         </dependency>
+
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+<!--            <version>5.5.2</version>-->

Review comment:
       delete annotated code.  <!--            <version>5.5.2</version>-->  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org