You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/11/06 02:43:01 UTC
[GitHub] XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update CI
test for PR #3977
XD-DENG edited a comment on issue #4138: [AIRFLOW-3301] Update CI test for PR #3977
URL: https://github.com/apache/incubator-airflow/pull/4138#issuecomment-436111972
Hi @deagon , in your PR https://github.com/apache/incubator-airflow/pull/3977, new argument `auto_remove` was added but the relevant test was not updated. This is causing CI failure (`tests.operators.test_docker_operator.DockerOperatorTestCase.test_execute`).
Details:
```
AssertionError: Expected call: create_host_config(binds=['/host/path:/container/path', '/mkdtemp:/tmp/airflow'], cpu_shares=1024, dns=None, dns_search=None, mem_limit=None, network_mode='bridge', shm_size=1000)
Actual call: create_host_config(auto_remove=False, binds=['/host/path:/container/path', '/mkdtemp:/tmp/airflow'], cpu_shares=1024, dns=None, dns_search=None, mem_limit=None, network_mode='bridge', shm_size=1000)
```
I have updated the relevant unit test here. FYI @Fokko @ashb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services