[jira] [Comment Edited] (CB-1156) Android app creation is broken in several ways!

["Anis Kadri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424370#comment-13424370 ] 

Anis Kadri edited comment on CB-1156 at 7/28/12 3:59 PM:
---------------------------------------------------------

{quote}
The experience of starting a new Android app is just really bad.
{quote}

We are truly deeply sorry about that.

{quote}
-> SplashScreen?!
I just can't understand why this is lacking. It is an obvious need & everyone has to waste time figuring out how to make it work by themselves
{quote}

It might be an obvious need for you but it doesn't necessarily apply to everyone. Apps like Wikipedia don't have it. People who don't want it will have to figure out how to remove it as well. I am not totally against it though. We can always make it possible but optional? Maybe discuss this on the ML ?

{quote}
-> MacOSX is broken
Either using latest Lion or any version with Macports + GNUTools (replacing deprecated versions bundled with OSX for licensing issues - common for most developers).
{quote}

Thanks for reporting this! OS X Lion was released two days ago. I just upgraded yesterday and did't get time to test. I fixed the replacement problem which uses absolute paths and should check the OSTYPE properly

{quote}
-> The XML is missing required keys (targetSDKpath) & having invalid stuff inside it (xLargeScreen).
{quote}

Do you mean `android:minSdkVersion` or `android:targetSdkVersion` ? We leave that up to the user. People who want to support higher versions of Android or don't want to support big screens can specify that themselves. By default we set `android:minSdkVersion` to API Level 8 (Android 2.2). Looks like this was recently modified from 5. We also build with the highest target.

{quote}
-> Most files are badly indented. Does not respect the Google guidelines for JAVA.
{quote}

Which files are we talking about exactly? Does it really matter if our files are not indented just as Eclipse would indent them ? None of us use eclipse…I see this as being really minor.


Other notes on your pull request:
- We won't be copying eclipse project files. People who want to use eclipse can still do so by creating android projects from source.
- I initially echoed everything like you did but I got some complaints from people who don't like verbosity so I got rid of it.
                
      was (Author: anis):
    {quote}
The experience of starting a new Android app is just really bad.
{quote}

We are truly deeply sorry about that.

{quote}
-> SplashScreen?!
I just can't understand why this is lacking. It is an obvious need & everyone has to waste time figuring out how to make it work by themselves
{quote}

It might be an obvious need for you but it doesn't necessarily apply to everyone. Apps like Wikipedia don't have it. People who don't want it will have to figure out how to remove it as well. I am not totally against it though. We can always make it possible but optional? Maybe discuss this on the ML ?

{quote}
-> MacOSX is broken
Either using latest Lion or any version with Macports + GNUTools (replacing deprecated versions bundled with OSX for licensing issues - common for most developers).
{quote}

Thanks for reporting this! OS X Lion was released two days ago. I just upgraded yesterday and did't get time to test. I fixed the replacement problem which uses absolute paths and should check the OSTYPE properly

{quote}
-> The XML is missing required keys (targetSDKpath) & having invalid stuff inside it (xLargeScreen).
{quote}

Do you mean `android:minSdkVersion` or `android:targetSdkVersion` ? We leave that up to the user. People who want to support higher versions of Android or don't want to support big screens can specify that themselves. By default we set `android:minSdkVersion` to API Level 8 (Android 2.2). Looks like this was recently modified from 5. We also build with the highest target.

{quote}
-> Most files are badly indented. Does not respect the Google guidelines for JAVA.
{quote}

Which files are we talking about exactly? Does it really matter if our files are not indented just as Eclipse would indent them ? None of us use eclipse…I see this as being really minor.


Other notes on your pull request:
- We won't be copy eclipse project files. People who want to use eclipse can still do so by creating android projects from source.
- I initially echoed everything like you did but I got some complaints from people who don't like verbosity so I got rid of it.
                  
> Android app creation is broken in several ways!
> -----------------------------------------------
>
>                 Key: CB-1156
>                 URL: https://issues.apache.org/jira/browse/CB-1156
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.0.0
>            Reporter: Olivier Louvignes
>            Assignee: Anis Kadri
>            Priority: Minor
>              Labels: android
>
> The experience of starting a new Android app is just really bad.
> When we use the bin/create script there is a lot of things missing :
> -> SplashScreen?!
> I just can't understand why this is lacking. It is an obvious need & everyone has to waste time figuring out how to make it work by themselves
> -> MacOSX is broken
> Either using latest Lion or any version with Macports + GNUTools (replacing deprecated versions bundled with OSX for licensing issues - common for most developers).
> -> The XML is missing required keys (targetSDKpath) & having invalid stuff inside it (xLargeScreen).
> -> Most files are badly indented. Does not respect the Google guidelines for JAVA.
> I've done most of the fixing myself:
> You can find this (work in progress) there :
> - https://github.com/mgcrea/incubator-cordova-android/commits/patches-create
> I'm quite disappointed on how you release a 2.0 without taking the hour needed to clean this mess. Instead a few hundred people will encounter the same issues & have a bad idea on Cordova/Phonegap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira