You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kishore Gopalakrishna <ki...@apache.org> on 2013/08/17 19:27:09 UTC
Review Request 13628: [HELIX-85] Removing mock service module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13628/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kanak Biscuitwala, and Shi Lu.
Repository: helix-git
Description
-------
Removing mock service module, the code is bad and not maintained.
Diffs
-----
mockservice/integration-test/mock.test 6c7b18f
mockservice/integration-test/nonexistent-get.test aad0bbe
mockservice/integration-test/simple-get.test af2248c
mockservice/integration-test/simple-post.test c015541
mockservice/integration-test/stop-service.test 7a163f6
mockservice/pom.xml fefed91
mockservice/src/main/config/log4j.properties 91fac03
mockservice/src/main/java/org/apache/helix/CMConnector.java ccc75af
mockservice/src/main/java/org/apache/helix/EspressoResource.java 64d725c
mockservice/src/main/java/org/apache/helix/EspressoStorageMockNode.java 777354f
mockservice/src/main/java/org/apache/helix/EspressoStorageMockStateModelFactory.java 69c5ab0
mockservice/src/main/java/org/apache/helix/FnvHashFunction.java fcd3af7
mockservice/src/main/java/org/apache/helix/HashFunction.java e5a5432
mockservice/src/main/java/org/apache/helix/MockEspressoService.java 5507ee3
mockservice/src/main/java/org/apache/helix/MockNode.java 4490e77
mockservice/src/main/java/org/apache/helix/MockNodeFactory.java e468fe8
mockservice/src/main/java/org/apache/helix/MockRunner.java 3467ab7
mockservice/src/main/java/org/apache/helix/StopServiceResource.java e2c670b
mockservice/src/test/conf/testng.xml 58f0803
mockservice/src/test/java/org/apache/helix/AppTest.java 25c53dd
pom.xml e708034
Diff: https://reviews.apache.org/r/13628/diff/
Testing
-------
Ran the build.
Thanks,
Kishore Gopalakrishna
Re: Review Request 13628: [HELIX-85] Removing mock service module
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13628/#review25274
-----------------------------------------------------------
Ship it!
Nothing at all worth salvaging?
- Kanak Biscuitwala
On Aug. 17, 2013, 5:27 p.m., Kishore Gopalakrishna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13628/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 5:27 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kanak Biscuitwala, and Shi Lu.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Removing mock service module, the code is bad and not maintained.
>
>
> Diffs
> -----
>
> mockservice/integration-test/mock.test 6c7b18f
> mockservice/integration-test/nonexistent-get.test aad0bbe
> mockservice/integration-test/simple-get.test af2248c
> mockservice/integration-test/simple-post.test c015541
> mockservice/integration-test/stop-service.test 7a163f6
> mockservice/pom.xml fefed91
> mockservice/src/main/config/log4j.properties 91fac03
> mockservice/src/main/java/org/apache/helix/CMConnector.java ccc75af
> mockservice/src/main/java/org/apache/helix/EspressoResource.java 64d725c
> mockservice/src/main/java/org/apache/helix/EspressoStorageMockNode.java 777354f
> mockservice/src/main/java/org/apache/helix/EspressoStorageMockStateModelFactory.java 69c5ab0
> mockservice/src/main/java/org/apache/helix/FnvHashFunction.java fcd3af7
> mockservice/src/main/java/org/apache/helix/HashFunction.java e5a5432
> mockservice/src/main/java/org/apache/helix/MockEspressoService.java 5507ee3
> mockservice/src/main/java/org/apache/helix/MockNode.java 4490e77
> mockservice/src/main/java/org/apache/helix/MockNodeFactory.java e468fe8
> mockservice/src/main/java/org/apache/helix/MockRunner.java 3467ab7
> mockservice/src/main/java/org/apache/helix/StopServiceResource.java e2c670b
> mockservice/src/test/conf/testng.xml 58f0803
> mockservice/src/test/java/org/apache/helix/AppTest.java 25c53dd
> pom.xml e708034
>
> Diff: https://reviews.apache.org/r/13628/diff/
>
>
> Testing
> -------
>
> Ran the build.
>
>
> Thanks,
>
> Kishore Gopalakrishna
>
>