You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/29 09:59:38 UTC
[GitHub] [dubbo] BurningCN opened a new pull request #9329: Code adjustment and optimization of config-api/common module
BurningCN opened a new pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329
## What is the purpose of the change
Code adjustment and optimization of config-api/common module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BurningCN commented on a change in pull request #9329: Code adjustment and optimization of config-api/common module
Posted by GitBox <gi...@apache.org>.
BurningCN commented on a change in pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329#discussion_r762724830
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
##########
@@ -241,7 +242,6 @@ public synchronized void destroy() {
ModuleServiceRepository repository = getScopeModel().getServiceRepository();
repository.unregisterConsumer(consumerModel);
}
- getScopeModel().getConfigManager().removeConfig(this);
Review comment:
The first step of the destroy method will call super.destroy, which is `ReferenceConfigBase#destroy`, and removeConfig has been executed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9329: Code adjustment and optimization of config-api/common module
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329#discussion_r762710070
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
##########
@@ -241,7 +242,6 @@ public synchronized void destroy() {
ModuleServiceRepository repository = getScopeModel().getServiceRepository();
repository.unregisterConsumer(consumerModel);
}
- getScopeModel().getConfigManager().removeConfig(this);
Review comment:
pls desc why remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9329: Code adjustment and optimization of config-api/common module
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BurningCN commented on a change in pull request #9329: Code adjustment and optimization of config-api/common module
Posted by GitBox <gi...@apache.org>.
BurningCN commented on a change in pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329#discussion_r762724830
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
##########
@@ -241,7 +242,6 @@ public synchronized void destroy() {
ModuleServiceRepository repository = getScopeModel().getServiceRepository();
repository.unregisterConsumer(consumerModel);
}
- getScopeModel().getConfigManager().removeConfig(this);
Review comment:
The first step of the destroy method will call super.destroy, which is `ReferenceConfigBase#destroy`, which has already done removeConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org