You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 20:45:35 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #10168: ARROW-12555: [Java][Release] Java post-release script misses dataset JNI bindings

kszucs commented on a change in pull request #10168:
URL: https://github.com/apache/arrow/pull/10168#discussion_r620635878



##########
File path: dev/release/post-11-java.sh
##########
@@ -39,24 +39,36 @@ curl \
 rm -rf ${archive_name}
 tar xf ${tar_gz}
 
+pushd ${archive_name}
+
+# clone the testing data to the appropiate directories
+git clone https://github.com/apache/arrow-testing testing
+git clone https://github.com/apache/parquet-testing.git cpp/submodules/parquet-testing
+
 # build the jni bindings similarly like the 01-perform.sh does
-mkdir -p ${archive_name}/cpp/java-build
-pushd ${archive_name}/cpp/java-build
+mkdir -p cpp/java-build
+pushd cpp/java-build
 cmake \
-  -DARROW_GANDIVA=ON \
+  -DARROW_DATASET=ON \

Review comment:
       Was added by https://github.com/apache/arrow/commit/d25660ed5f57b167878c96cafc23361421a73ca8




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org