You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/11 03:32:33 UTC
[GitHub] [dubbo-samples] shengchaojie opened a new pull request #249: fix dubbo-samples-generic it case
shengchaojie opened a new pull request #249:
URL: https://github.com/apache/dubbo-samples/pull/249
fix dubbo-samples-generic it case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #249: fix dubbo-samples-generic it case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #249:
URL: https://github.com/apache/dubbo-samples/pull/249#discussion_r555482240
##########
File path: dubbo-samples-generic/dubbo-samples-generic-call/dubbo-samples-generic-call-api/pom.xml
##########
@@ -1,34 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
Review comment:
这几个pom.xml为什么删除了？
##########
File path: dubbo-samples-generic/dubbo-samples-generic-call/pom.xml
##########
@@ -27,21 +27,68 @@
<version>1.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>
- <packaging>pom</packaging>
+ <packaging>jar</packaging>
<artifactId>dubbo-samples-generic-call</artifactId>
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
+ <dubbo.version>2.7.7</dubbo.version>
+ <spring.version>4.3.16.RELEASE</spring.version>
+ <junit.version>4.12</junit.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
</properties>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
+ <version>${spring.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-bom</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
- <modules>
- <module>dubbo-samples-generic-call-api</module>
Review comment:
不应该改变原来的module划分
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] shengchaojie closed pull request #249: fix dubbo-samples-generic it case
Posted by GitBox <gi...@apache.org>.
shengchaojie closed pull request #249:
URL: https://github.com/apache/dubbo-samples/pull/249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org