You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2013/04/30 14:02:16 UTC
[jira] [Resolved] (COLLECTIONS-458)
AbstractUntypedCollectionDecorator is not used
[ https://issues.apache.org/jira/browse/COLLECTIONS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved COLLECTIONS-458.
------------------------------
Resolution: Fixed
URL: http://svn.apache.org/r1477514
Log:
COLLECTIONS-458 AbstractUntypedCollectionDecorator<E, D> is not used
Removed:
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/collection/AbstractUntypedCollectionDecorator.java
Modified:
commons/proper/collections/trunk/src/changes/changes.xml
> AbstractUntypedCollectionDecorator<E, D> is not used
> -----------------------------------------------------
>
> Key: COLLECTIONS-458
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-458
> Project: Commons Collections
> Issue Type: Bug
> Reporter: Sebb
>
> The public ctor for AbstractUntypedCollectionDecorator<E, D> takes no argument and so collection = null; however the protected ctor checks for collection parameter != null.
> The decorated() method says that all access to collection goes through it, and there is no setter.
> At present the only way to recover from calling the public ctor is for the sub-class to set collection directly.
> This is inconsistent.
> The class is abstract and there appear to be no concrete subclasses. Looks like the class might be superfluous, but if it is required, it should ideally have a private final collection field.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira