You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2010/09/16 00:57:54 UTC

svn propchange: r997420 - svn:log

Author: doogie
Revision: 997420
Modified property: svn:log

Modified: svn:log at Wed Sep 15 22:57:54 2010
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Wed Sep 15 22:57:54 2010
@@ -1,3 +1,8 @@
-Fix incorrect use of window->load event, instead doing
-document->dom:loaded.  In internet explorer, the window->load event can
-happen before the document is actually parsed and converted to DOM nodes.
+Some places in ofbiz were doing dom manipulation without waiting for the
+dom to be finished loading.  Wrap such code with a dom:loaded observer.
+
+Also, change all window->load calls to dom:loaded observers.  The former
+happens after all images have finished loading, while the later happens
+just after the dom has finished parsing.  This is better, as sometimes
+the images may take a long time to finish downloading, and until they do,
+none of the manipulation will take place.


Re: svn propchange: r997420 - svn:log

Posted by Jacques Le Roux <ja...@les7arts.com>.
Great, I will have a good night (except if you forget the others, but anyway I'm already sleeping :D

Jacques

From: <do...@apache.org>
> Author: doogie
> Revision: 997420
> Modified property: svn:log
> 
> Modified: svn:log at Wed Sep 15 22:57:54 2010
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Wed Sep 15 22:57:54 2010
> @@ -1,3 +1,8 @@
> -Fix incorrect use of window->load event, instead doing
> -document->dom:loaded.  In internet explorer, the window->load event can
> -happen before the document is actually parsed and converted to DOM nodes.
> +Some places in ofbiz were doing dom manipulation without waiting for the
> +dom to be finished loading.  Wrap such code with a dom:loaded observer.
> +
> +Also, change all window->load calls to dom:loaded observers.  The former
> +happens after all images have finished loading, while the later happens
> +just after the dom has finished parsing.  This is better, as sometimes
> +the images may take a long time to finish downloading, and until they do,
> +none of the manipulation will take place.
>