You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/15 19:07:04 UTC
Review Request 64656: Added validation for VIEW_STANDALONE_CONTAINER
ACL.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64656/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Greg Mann.
Repository: mesos
Description
-------
Added validation for VIEW_STANDALONE_CONTAINER ACL.
Diffs
-----
src/authorizer/local/authorizer.cpp 09f26185a14e563b79dedd66caaf323b6c3f9abc
Diff: https://reviews.apache.org/r/64656/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 64656: Added validation for
VIEW_STANDALONE_CONTAINER ACL.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64656/#review193986
-----------------------------------------------------------
Fix it, then Ship it!
src/authorizer/local/authorizer.cpp
Lines 1674 (patched)
<https://reviews.apache.org/r/64656/#comment272679>
s/container/containers/
It's too bad the other standalone container ACL field names are not plural...
- Greg Mann
On Dec. 15, 2017, 7:07 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64656/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 7:07 p.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for VIEW_STANDALONE_CONTAINER ACL.
>
>
> Diffs
> -----
>
> src/authorizer/local/authorizer.cpp 09f26185a14e563b79dedd66caaf323b6c3f9abc
>
>
> Diff: https://reviews.apache.org/r/64656/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>