You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/01/31 13:02:10 UTC
[43/50] incubator-kylin git commit: clear warning in job module
clear warning in job module
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/f9ca3a04
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/f9ca3a04
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/f9ca3a04
Branch: refs/heads/inverted-index
Commit: f9ca3a0416e458916b92a7ac58fde18c76100541
Parents: e94bcda
Author: Li, Yang <ya...@ebay.com>
Authored: Thu Jan 29 17:42:40 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Thu Jan 29 17:42:40 2015 +0800
----------------------------------------------------------------------
.../java/com/kylinolap/job/CubeMetadataUpgrade.java | 1 +
.../com/kylinolap/job/common/HqlExecutable.java | 4 ++--
.../com/kylinolap/job/common/ShellExecutable.java | 16 ++++++++--------
.../com/kylinolap/job/dao/ExecutableOutputPO.java | 6 ++----
.../java/com/kylinolap/job/dao/ExecutablePO.java | 7 +++----
.../cardinality/HiveColumnCardinalityJob.java | 8 --------
.../cardinality/HiveColumnCardinalityUpdateJob.java | 10 ----------
.../com/kylinolap/job/hadoop/cube/CubeHFileJob.java | 2 --
.../kylinolap/job/hadoop/cube/MergeCuboidJob.java | 4 ----
.../com/kylinolap/job/BuildCubeWithEngineTest.java | 6 ++++++
.../com/kylinolap/job/BuildIIWithEngineTest.java | 1 +
job/src/test/java/com/kylinolap/job/DeployUtil.java | 2 --
.../job/hadoop/cube/BaseCuboidJobTest.java | 1 -
.../job/impl/threadpool/DefaultSchedulerTest.java | 15 +++++++++------
14 files changed, 32 insertions(+), 51 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/CubeMetadataUpgrade.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/CubeMetadataUpgrade.java b/job/src/main/java/com/kylinolap/job/CubeMetadataUpgrade.java
index b9775a7..edc4996 100644
--- a/job/src/main/java/com/kylinolap/job/CubeMetadataUpgrade.java
+++ b/job/src/main/java/com/kylinolap/job/CubeMetadataUpgrade.java
@@ -167,6 +167,7 @@ public class CubeMetadataUpgrade {
}
+ @SuppressWarnings("unchecked")
private void upgradeTableDesceExd() {
List<String> paths = listResourceStore(ResourceStore.TABLE_EXD_RESOURCE_ROOT);
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/common/HqlExecutable.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/common/HqlExecutable.java b/job/src/main/java/com/kylinolap/job/common/HqlExecutable.java
index f5ee1f1..eb7cf4e 100644
--- a/job/src/main/java/com/kylinolap/job/common/HqlExecutable.java
+++ b/job/src/main/java/com/kylinolap/job/common/HqlExecutable.java
@@ -11,11 +11,10 @@ import com.fasterxml.jackson.core.JsonProcessingException;
import com.google.common.collect.Lists;
import com.kylinolap.common.util.HiveClient;
import com.kylinolap.common.util.JsonUtil;
-import com.kylinolap.job.dao.ExecutablePO;
import com.kylinolap.job.exception.ExecuteException;
+import com.kylinolap.job.execution.AbstractExecutable;
import com.kylinolap.job.execution.ExecutableContext;
import com.kylinolap.job.execution.ExecuteResult;
-import com.kylinolap.job.execution.AbstractExecutable;
/**
* Created by qianzhou on 1/15/15.
@@ -58,6 +57,7 @@ public class HqlExecutable extends AbstractExecutable {
}
+ @SuppressWarnings("unchecked")
private Map<String, String> getConfiguration() {
String configStr = getParam(HIVE_CONFIG);
Map<String, String> result = null;
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/common/ShellExecutable.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/common/ShellExecutable.java b/job/src/main/java/com/kylinolap/job/common/ShellExecutable.java
index 2b454d6..6d9391b 100644
--- a/job/src/main/java/com/kylinolap/job/common/ShellExecutable.java
+++ b/job/src/main/java/com/kylinolap/job/common/ShellExecutable.java
@@ -1,19 +1,19 @@
package com.kylinolap.job.common;
+import java.io.IOException;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hbase.util.Pair;
+
import com.google.common.collect.Maps;
import com.kylinolap.common.util.Logger;
import com.kylinolap.job.constant.ExecutableConstants;
-import com.kylinolap.job.dao.ExecutablePO;
import com.kylinolap.job.exception.ExecuteException;
+import com.kylinolap.job.execution.AbstractExecutable;
import com.kylinolap.job.execution.ExecutableContext;
import com.kylinolap.job.execution.ExecuteResult;
-import com.kylinolap.job.execution.AbstractExecutable;
-import org.apache.hadoop.hbase.util.Pair;
-
-import java.io.IOException;
-import java.util.Map;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
/**
* Created by qianzhou on 12/26/14.
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/dao/ExecutableOutputPO.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/dao/ExecutableOutputPO.java b/job/src/main/java/com/kylinolap/job/dao/ExecutableOutputPO.java
index 9c6ad78..ab014e1 100644
--- a/job/src/main/java/com/kylinolap/job/dao/ExecutableOutputPO.java
+++ b/job/src/main/java/com/kylinolap/job/dao/ExecutableOutputPO.java
@@ -1,13 +1,11 @@
package com.kylinolap.job.dao;
+import java.util.Map;
+
import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.collect.Maps;
import com.kylinolap.common.persistence.RootPersistentEntity;
-import com.kylinolap.job.execution.ExecutableState;
-
-import java.util.List;
-import java.util.Map;
/**
* Created by qianzhou on 12/15/14.
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/dao/ExecutablePO.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/dao/ExecutablePO.java b/job/src/main/java/com/kylinolap/job/dao/ExecutablePO.java
index dd55d99..1a1b279 100644
--- a/job/src/main/java/com/kylinolap/job/dao/ExecutablePO.java
+++ b/job/src/main/java/com/kylinolap/job/dao/ExecutablePO.java
@@ -1,14 +1,13 @@
package com.kylinolap.job.dao;
+import java.util.List;
+import java.util.Map;
+
import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.JsonProperty;
-import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.kylinolap.common.persistence.RootPersistentEntity;
-import java.util.List;
-import java.util.Map;
-
/**
* Created by qianzhou on 12/15/14.
*/
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityJob.java b/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityJob.java
index 52f1491..88ea3ef 100644
--- a/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityJob.java
+++ b/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityJob.java
@@ -54,21 +54,13 @@ public class HiveColumnCardinalityJob extends AbstractHadoopJob {
private String table;
- /**
- * MRJobConfig.MAPREDUCE_JOB_CREDENTIALS_BINARY
- */
- private String tokenPath;
-
public HiveColumnCardinalityJob() {
-
}
public HiveColumnCardinalityJob(String path, String tokenPath) {
this.jarPath = path;
- this.tokenPath = tokenPath;
}
- @SuppressWarnings("unchecked")
@Override
public int run(String[] args) throws Exception {
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityUpdateJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityUpdateJob.java b/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityUpdateJob.java
index 03b1f37..8af6556 100644
--- a/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityUpdateJob.java
+++ b/job/src/main/java/com/kylinolap/job/hadoop/cardinality/HiveColumnCardinalityUpdateJob.java
@@ -52,22 +52,12 @@ public class HiveColumnCardinalityUpdateJob extends AbstractHadoopJob {
@SuppressWarnings("static-access")
protected static final Option OPTION_TABLE = OptionBuilder.withArgName("table name").hasArg().isRequired(true).withDescription("The hive table name").create("table");
- /**
- * This is the jar path
- */
-
private String table;
- /**
- * MRJobConfig.MAPREDUCE_JOB_CREDENTIALS_BINARY
- */
-
public HiveColumnCardinalityUpdateJob() {
}
-
- @SuppressWarnings("unchecked")
@Override
public int run(String[] args) throws Exception {
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/hadoop/cube/CubeHFileJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/hadoop/cube/CubeHFileJob.java b/job/src/main/java/com/kylinolap/job/hadoop/cube/CubeHFileJob.java
index 89b6b70..d9cf0bc 100644
--- a/job/src/main/java/com/kylinolap/job/hadoop/cube/CubeHFileJob.java
+++ b/job/src/main/java/com/kylinolap/job/hadoop/cube/CubeHFileJob.java
@@ -40,9 +40,7 @@ import com.kylinolap.job.hadoop.AbstractHadoopJob;
/**
* @author George Song (ysong1)
- *
*/
-
public class CubeHFileJob extends AbstractHadoopJob {
protected static final Logger logger = LoggerFactory.getLogger(CubeHFileJob.class);
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/main/java/com/kylinolap/job/hadoop/cube/MergeCuboidJob.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/com/kylinolap/job/hadoop/cube/MergeCuboidJob.java b/job/src/main/java/com/kylinolap/job/hadoop/cube/MergeCuboidJob.java
index 3b8ff89..6d61457 100644
--- a/job/src/main/java/com/kylinolap/job/hadoop/cube/MergeCuboidJob.java
+++ b/job/src/main/java/com/kylinolap/job/hadoop/cube/MergeCuboidJob.java
@@ -25,8 +25,6 @@ import org.apache.hadoop.mapreduce.Job;
import org.apache.hadoop.mapreduce.lib.input.SequenceFileInputFormat;
import org.apache.hadoop.mapreduce.lib.output.FileOutputFormat;
import org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import com.kylinolap.common.KylinConfig;
import com.kylinolap.cube.CubeInstance;
@@ -38,8 +36,6 @@ import com.kylinolap.job.constant.BatchConstants;
*/
public class MergeCuboidJob extends CuboidJob {
- private static final Logger log = LoggerFactory.getLogger(MergeCuboidJob.class);
-
@Override
public int run(String[] args) throws Exception {
Options options = new Options();
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/test/java/com/kylinolap/job/BuildCubeWithEngineTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/com/kylinolap/job/BuildCubeWithEngineTest.java b/job/src/test/java/com/kylinolap/job/BuildCubeWithEngineTest.java
index 8e62685..c24d6d6 100644
--- a/job/src/test/java/com/kylinolap/job/BuildCubeWithEngineTest.java
+++ b/job/src/test/java/com/kylinolap/job/BuildCubeWithEngineTest.java
@@ -16,6 +16,7 @@ import com.kylinolap.job.execution.ExecutableState;
import com.kylinolap.job.hadoop.cube.StorageCleanupJob;
import com.kylinolap.job.impl.threadpool.DefaultScheduler;
import com.kylinolap.job.manager.ExecutableManager;
+
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.util.ToolRunner;
@@ -161,6 +162,7 @@ public class BuildCubeWithEngineTest {
this.countDownLatch = countDownLatch;
}
+ @SuppressWarnings("unchecked")
@Override
public List<String> call() throws Exception {
try {
@@ -173,6 +175,7 @@ public class BuildCubeWithEngineTest {
}
}
+ @SuppressWarnings("unused") // called by reflection
private List<String> testInnerJoinCube2() throws Exception {
clearSegment("test_kylin_cube_with_slr_empty");
SimpleDateFormat f = new SimpleDateFormat("yyyy-MM-dd");
@@ -186,6 +189,7 @@ public class BuildCubeWithEngineTest {
return result;
}
+ @SuppressWarnings("unused") // called by reflection
private List<String> testInnerJoinCube() throws Exception {
clearSegment("test_kylin_cube_without_slr_empty");
@@ -205,6 +209,7 @@ public class BuildCubeWithEngineTest {
return result;
}
+ @SuppressWarnings("unused") // called by reflection
private List<String> testLeftJoinCube2() throws Exception {
SimpleDateFormat f = new SimpleDateFormat("yyyy-MM-dd");
f.setTimeZone(TimeZone.getTimeZone("GMT"));
@@ -226,6 +231,7 @@ public class BuildCubeWithEngineTest {
}
+ @SuppressWarnings("unused") // called by reflection
private List<String> testLeftJoinCube() throws Exception {
String cubeName = "test_kylin_cube_with_slr_left_join_empty";
clearSegment(cubeName);
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/test/java/com/kylinolap/job/BuildIIWithEngineTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/com/kylinolap/job/BuildIIWithEngineTest.java b/job/src/test/java/com/kylinolap/job/BuildIIWithEngineTest.java
index c426c64..df6d5f4 100644
--- a/job/src/test/java/com/kylinolap/job/BuildIIWithEngineTest.java
+++ b/job/src/test/java/com/kylinolap/job/BuildIIWithEngineTest.java
@@ -141,6 +141,7 @@ public class BuildIIWithEngineTest {
this.countDownLatch = countDownLatch;
}
+ @SuppressWarnings("unchecked")
@Override
public List<String> call() throws Exception {
try {
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/test/java/com/kylinolap/job/DeployUtil.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/com/kylinolap/job/DeployUtil.java b/job/src/test/java/com/kylinolap/job/DeployUtil.java
index 6794aa9..9e523d2 100644
--- a/job/src/test/java/com/kylinolap/job/DeployUtil.java
+++ b/job/src/test/java/com/kylinolap/job/DeployUtil.java
@@ -24,9 +24,7 @@ import com.kylinolap.common.util.HiveClient;
import com.kylinolap.cube.CubeInstance;
import com.kylinolap.cube.CubeManager;
import com.kylinolap.job.dataGen.FactTableGenerator;
-import com.kylinolap.job.engine.JobEngineConfig;
import com.kylinolap.job.hadoop.hive.SqlHiveDataTypeMapping;
-import com.kylinolap.job.tools.LZOSupportnessChecker;
import com.kylinolap.metadata.MetadataManager;
import com.kylinolap.metadata.model.ColumnDesc;
import com.kylinolap.metadata.model.TableDesc;
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/test/java/com/kylinolap/job/hadoop/cube/BaseCuboidJobTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/com/kylinolap/job/hadoop/cube/BaseCuboidJobTest.java b/job/src/test/java/com/kylinolap/job/hadoop/cube/BaseCuboidJobTest.java
index 2899e22..2385b6e 100644
--- a/job/src/test/java/com/kylinolap/job/hadoop/cube/BaseCuboidJobTest.java
+++ b/job/src/test/java/com/kylinolap/job/hadoop/cube/BaseCuboidJobTest.java
@@ -26,7 +26,6 @@ import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import com.kylinolap.common.util.AbstractKylinTestCase;
import com.kylinolap.common.util.LocalFileMetadataTestCase;
/**
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f9ca3a04/job/src/test/java/com/kylinolap/job/impl/threadpool/DefaultSchedulerTest.java
----------------------------------------------------------------------
diff --git a/job/src/test/java/com/kylinolap/job/impl/threadpool/DefaultSchedulerTest.java b/job/src/test/java/com/kylinolap/job/impl/threadpool/DefaultSchedulerTest.java
index 5ba3f94..d0cb157 100644
--- a/job/src/test/java/com/kylinolap/job/impl/threadpool/DefaultSchedulerTest.java
+++ b/job/src/test/java/com/kylinolap/job/impl/threadpool/DefaultSchedulerTest.java
@@ -1,13 +1,16 @@
package com.kylinolap.job.impl.threadpool;
-import com.kylinolap.job.*;
-import com.kylinolap.job.execution.DefaultChainedExecutable;
-import com.kylinolap.job.execution.ExecutableState;
+import static org.junit.Assert.*;
+
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.fail;
+import com.kylinolap.job.BaseTestExecutable;
+import com.kylinolap.job.ErrorTestExecutable;
+import com.kylinolap.job.FailedTestExecutable;
+import com.kylinolap.job.SelfStopExecutable;
+import com.kylinolap.job.SucceedTestExecutable;
+import com.kylinolap.job.execution.DefaultChainedExecutable;
+import com.kylinolap.job.execution.ExecutableState;
/**
* Created by qianzhou on 12/19/14.