You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:34:41 UTC

[GitHub] [plc4x] hutcheb opened a new pull request, #341: Feature/plc4py bh1

hutcheb opened a new pull request, #341:
URL: https://github.com/apache/plc4x/pull/341

   Add Pluggy Framework
   Fixed type hinting issues with the help of mypy
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #341: Feature/plc4py bh1

Posted by GitBox <gi...@apache.org>.
ottobackwards commented on PR #341:
URL: https://github.com/apache/plc4x/pull/341#issuecomment-1091634460

   I don't think you have to register them manually, I think that they can register themselves using the setuptools / setup config.
   
   So, if we start out with 1 plc4py whl file, it's setup can register all the distributed drivers like.
   
   https://pluggy.readthedocs.io/en/stable/#loading-setuptools-entry-points


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #341: Feature/plc4py bh1

Posted by GitBox <gi...@apache.org>.
ottobackwards commented on PR #341:
URL: https://github.com/apache/plc4x/pull/341#issuecomment-1094288452

   sounds great


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #341: Feature/plc4py bh1

Posted by GitBox <gi...@apache.org>.
hutcheb commented on PR #341:
URL: https://github.com/apache/plc4x/pull/341#issuecomment-1094148514

   Yeah found a way forward with adding the plugins to the poetry config.
   I've also added an abtract class PlcConnectionLoader, almost feels a bit of a duplicate of the hookspec but I think it is better.
   
   Yeah I've left off some of the docstrings, I've updated most but still left some of the stub files.
   
   I'll rebase and merge it soon
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] hutcheb merged pull request #341: Feature/plc4py bh1

Posted by GitBox <gi...@apache.org>.
hutcheb merged PR #341:
URL: https://github.com/apache/plc4x/pull/341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #341: Feature/plc4py bh1

Posted by GitBox <gi...@apache.org>.
hutcheb commented on PR #341:
URL: https://github.com/apache/plc4x/pull/341#issuecomment-1090586423

   Thanks Otto,
   
   The Pluggy stuff definitely needs some work, I'm not happy with having to register the driver manually, kind of misses the point of using Pluggy.
   
   I spent a bit of time trying to figure it out and moved on to have something that works. I'll take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org