You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "mikyll (via GitHub)" <gi...@apache.org> on 2026/04/20 16:09:56 UTC
[PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
mikyll opened a new pull request, #13264:
URL: https://github.com/apache/apisix/pull/13264
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
This PR introduces support for resolving the API key value from a secret (env var or secret manager), as detailed in [APISIX Docs | Secret](https://apisix.apache.org/docs/apisix/terminology/secret/). This can prevent writing the plain text value of the secret in the plugin configuration.
#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #13233
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #13264:
URL: https://github.com/apache/apisix/pull/13264#issuecomment-4294208328
Hi @mikyll, could you please fix the failed ci?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "mikyll (via GitHub)" <gi...@apache.org>.
mikyll commented on PR #13264:
URL: https://github.com/apache/apisix/pull/13264#issuecomment-4489328930
Hi @Baoyuantop, any update on this? 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #13264:
URL: https://github.com/apache/apisix/pull/13264#issuecomment-4600014931
Thanks for continuing to update this PR. The current base already includes #13312, which added central secret resolution for all plugin configurations. `plugin.filter()` resolves `$ENV://...` and `$secret://...` references before plugin execution, and it uses `_no_secret_ref` / `_resolved_cache` to avoid deep-copying plugin configuration on every request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "mikyll (via GitHub)" <gi...@apache.org>.
mikyll commented on PR #13264:
URL: https://github.com/apache/apisix/pull/13264#issuecomment-4612311390
Ok, then this PR is no longer needed 👀
The same applies to https://github.com/apache/apisix/pull/13143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "mikyll (via GitHub)" <gi...@apache.org>.
mikyll commented on PR #13264:
URL: https://github.com/apache/apisix/pull/13264#issuecomment-4294776110
@Baoyuantop I pushed a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ai-rag): support resolving secrets from environment variables and secret vaults [apisix]
Posted by "mikyll (via GitHub)" <gi...@apache.org>.
mikyll closed pull request #13264: feat(ai-rag): support resolving secrets from environment variables and secret vaults
URL: https://github.com/apache/apisix/pull/13264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org