You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 19:20:05 UTC
[GitHub] [airflow] arminnajafi opened a new issue, #24421: Airflow pining old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
arminnajafi opened a new issue, #24421:
URL: https://github.com/apache/airflow/issues/24421
### Apache Airflow version
2.3.2 (latest released)
### What happened
Hello Airflow is pinning old version of attrs and this is leading to version conflict on our side to use Airflow.
```
And because every version of aws-cdk-lib requires attrs (>=21.2,<22.0) or jsii (>=1.58.0,<2.0.0) (4), every version of aws-cdk-lib requires attrs (>=21.2,<22.0)
Because no versions of apache-airflow match >2.3.2,<3.0.0
and apache-airflow (2.3.2) depends on attrs (>=20.0,<21.0), apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0).
Thus, apache-airflow (>=2.3.2,<3.0.0) is incompatible with aws-cdk-lib.
```
### What you think should happen instead
Please upgrade attrs to >=21
### How to reproduce
_No response_
### Operating System
macOS Monterey - 12.3.1
### Versions of Apache Airflow Providers
_No response_
### Deployment
Virtualenv installation
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154707827
Also note that the `setup.cfg` contains some reasoning:
```
# We limit the version of attrs to work with the old version of cattrs
attrs>=20.0,<21.0
# Cattrs upgrades were known to break lineage https://github.com/apache/airflow/issues/16172
# TODO: Cattrs is now at 3.8 version so we should attempt to upgrade cattrs soon.
cattrs~=1.1, !=1.7.*
```
You can use `git blame` to find the corresponding issues that added these comments. They provide context for you to evaluate whether upgrades are viable, and how they can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #24421: Airflow pining old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154338264
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154341345
Assigned it to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tomsej commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
tomsej commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1216815974
Think this can be closed. See https://github.com/apache/airflow/pull/25689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154341050
Feel free to PR it. - just remove the lmit frmo setup.cfg and solve any problems it might generate..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154361692
Yes/ Follow those.. CI will run all the tests as well when you push a change to setup.cfg. Updating requirements is a little more involved (You need to build image with `--upgrade-to-newer-dependencies` flag if you change dependencies and want to re-run test locally using `breeze`. This is the only difference vs. standard contribution guildelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] arminnajafi commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
arminnajafi commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154359395
@potiuk
Thanks.
Any guidelines/pointers on how to get my environment set up and make sure tests pass after my changes?
I assume I just need to follow https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
URL: https://github.com/apache/airflow/issues/24421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1154362520
There might be also other dependencies holding it back, so you need to check which versions you get when you build the image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24421: Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24421:
URL: https://github.com/apache/airflow/issues/24421#issuecomment-1159789315
Any news @arminnajafi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org