You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by prateek vaishnav <pr...@inmobi.com> on 2016/02/08 12:55:08 UTC
Review Request 43327: Fixed few unit test cases in
"TestEvalPipelineLocal" Test group
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43327/
-----------------------------------------------------------
Review request for pig.
Bugs: https://issues.apache.org/jira/browse/PIG-4777
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-4777
Repository: pig-git
Description
-------
https://issues.apache.org/jira/browse/PIG-4777
Following unit tests have been fixed -
org.apache.pig.test.TestEvalPipelineLocal.testArithmeticCloning
org.apache.pig.test.TestEvalPipelineLocal.testGroupByTuple
org.apache.pig.test.TestEvalPipelineLocal.testNestedPlanForCloning
org.apache.pig.test.TestEvalPipelineLocal.testExpressionReUse
All above unit testcases were failing due to output coming from spark was in a different order than expected.
Diffs
-----
test/org/apache/pig/test/TestEvalPipelineLocal.java c12d595
Diff: https://reviews.apache.org/r/43327/diff/
Testing
-------
These unit tests are running successfully on spark, mr and on local.
Thanks,
prateek vaishnav
Re: Review Request 43327: Fixed few unit test cases in
"TestEvalPipelineLocal" Test group
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43327/#review118980
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Feb. 11, 2016, 12:51 p.m., prateek vaishnav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43327/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:51 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: https://issues.apache.org/jira/browse/PIG-4777
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-4777
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/PIG-4777
>
> Following unit tests have been fixed -
> org.apache.pig.test.TestEvalPipelineLocal.testArithmeticCloning
> org.apache.pig.test.TestEvalPipelineLocal.testGroupByTuple
> org.apache.pig.test.TestEvalPipelineLocal.testNestedPlanForCloning
> org.apache.pig.test.TestEvalPipelineLocal.testExpressionReUse
>
> All above unit testcases were failing due to output coming from spark was in a different order than expected.
>
>
> Diffs
> -----
>
> test/org/apache/pig/test/TestEvalPipelineLocal.java c12d595
>
> Diff: https://reviews.apache.org/r/43327/diff/
>
>
> Testing
> -------
>
> These unit tests are running successfully on spark, mr and on local.
>
>
> Thanks,
>
> prateek vaishnav
>
>
Re: Review Request 43327: Fixed few unit test cases in
"TestEvalPipelineLocal" Test group
Posted by prateek vaishnav <pr...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43327/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 12:51 p.m.)
Review request for pig.
Changes
-------
Addressing review comments.
Bugs: https://issues.apache.org/jira/browse/PIG-4777
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-4777
Repository: pig-git
Description
-------
https://issues.apache.org/jira/browse/PIG-4777
Following unit tests have been fixed -
org.apache.pig.test.TestEvalPipelineLocal.testArithmeticCloning
org.apache.pig.test.TestEvalPipelineLocal.testGroupByTuple
org.apache.pig.test.TestEvalPipelineLocal.testNestedPlanForCloning
org.apache.pig.test.TestEvalPipelineLocal.testExpressionReUse
All above unit testcases were failing due to output coming from spark was in a different order than expected.
Diffs (updated)
-----
test/org/apache/pig/test/TestEvalPipelineLocal.java c12d595
Diff: https://reviews.apache.org/r/43327/diff/
Testing
-------
These unit tests are running successfully on spark, mr and on local.
Thanks,
prateek vaishnav
Re: Review Request 43327: Fixed few unit test cases in
"TestEvalPipelineLocal" Test group
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43327/#review118815
-----------------------------------------------------------
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 892)
<https://reviews.apache.org/r/43327/#comment180114>
Don't say random order, please say different order :-)
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 896)
<https://reviews.apache.org/r/43327/#comment180117>
You don't need numIdentity any longer. You can use resList.size()
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 942)
<https://reviews.apache.org/r/43327/#comment180118>
different order. Change in other places too.
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 947)
<https://reviews.apache.org/r/43327/#comment180119>
numRows not required
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 955)
<https://reviews.apache.org/r/43327/#comment180123>
Move this generation of expected result up into the previous loop on line 910, so we loop through multiple times.
test/org/apache/pig/test/TestEvalPipelineLocal.java (line 1012)
<https://reviews.apache.org/r/43327/#comment180125>
Can move this looping up.
- Pallavi Rao
On Feb. 8, 2016, 11:55 a.m., prateek vaishnav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43327/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 11:55 a.m.)
>
>
> Review request for pig.
>
>
> Bugs: https://issues.apache.org/jira/browse/PIG-4777
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-4777
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/PIG-4777
>
> Following unit tests have been fixed -
> org.apache.pig.test.TestEvalPipelineLocal.testArithmeticCloning
> org.apache.pig.test.TestEvalPipelineLocal.testGroupByTuple
> org.apache.pig.test.TestEvalPipelineLocal.testNestedPlanForCloning
> org.apache.pig.test.TestEvalPipelineLocal.testExpressionReUse
>
> All above unit testcases were failing due to output coming from spark was in a different order than expected.
>
>
> Diffs
> -----
>
> test/org/apache/pig/test/TestEvalPipelineLocal.java c12d595
>
> Diff: https://reviews.apache.org/r/43327/diff/
>
>
> Testing
> -------
>
> These unit tests are running successfully on spark, mr and on local.
>
>
> Thanks,
>
> prateek vaishnav
>
>