[GitHub] [guacamole-client] necouchman commented on a change in pull request #578: GUACAMOLE-221: Expose underlying protocol at tunnel level.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #578:
URL: https://github.com/apache/guacamole-client/pull/578#discussion_r530354598



##########
File path: guacamole-common/pom.xml
##########
@@ -57,14 +57,14 @@
     <build>
         <plugins>
 
-            <!-- Written for 1.6 -->
+            <!-- Written for 1.8 -->

Review comment:
       <snif, snif>
   
   Alas, poor Java 6.

##########
File path: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
##########
@@ -201,87 +201,54 @@ protected abstract void release(RemoteAuthenticatedUser user,
             ModeledConnectionGroup connectionGroup);
 
     /**
-     * Returns a guacamole configuration containing the protocol and parameters
-     * from the given connection. If the ID of an active connection is
-     * provided, that connection will be joined instead of starting a new
-     * primary connection. If tokens are used in the connection parameter
-     * values, credentials from the given user will be substituted
-     * appropriately.
-     *
-     * @param user
-     *     The user whose credentials should be used if necessary.
+     * Returns a GuacamoleConfiguration which connects to the given connection.
+     * If the connection ID of an active is provided, that active connection
+     * will be joined rather than establishing an entirely new connection. If
+     * a sharing profile is provided, the parameters associated with that
+     * sharing profile will be used to define the access provided to the user
+     * accessing the shared connection. If tokens are used in the connection
+     * parameter values of the sharing profile, credentials from the given user
+     * will be substituted appropriately.

Review comment:
       A couple of minor issues with the wording, here:
   * This makes it sounds like tokens will only be substituted for sharing profiles and not for normal connections. But, looking at the code, it looks like this is true of either case?
   * It also makes it sound like tokens would only apply to credentials? But this would be true of any connection parameter or token (date/time, LDAP attributes, etc.), correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org