You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2024/07/19 09:37:24 UTC

[PR] Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

epugh opened a new pull request, #2573:
URL: https://github.com/apache/solr/pull/2573

   # Description
   
   [SOLR-17357](https://issues.apache.org/jira/browse/SOLR-17357): Improve SolrCLI tool --help printout introduced a new format for the usage description.   Some bats tests appear to not have been updated to match.
   
   # Solution
   
   Introduce the `bin/solr` part to the usage command checks to match what ` SolrCLI.printToolHelp` does.
   
   # Tests
   
   Manually rans BATS tests.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2573:
URL: https://github.com/apache/solr/pull/2573#issuecomment-2239297975

   I ran the bats tests on branch_9x now, and these failed:
   ```bash
   not ok 38 create help flag prints help in 1000ms
   not ok 39 delete help flag prints help in 1000ms
   not ok 40 version help flag prints help in 0ms
   not ok 43 assert help flag prints help in 0ms
   not ok 44 post help flag prints help in 1000ms
   not ok 53 Check help command in 2000ms
   ```
   This means that this PR can be back-ported to branch_9x, except for the first one `healthcheck help flag prints help`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2573:
URL: https://github.com/apache/solr/pull/2573#issuecomment-2239299893

   So I think this is good to merge now. 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17357 Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2573:
URL: https://github.com/apache/solr/pull/2573#issuecomment-2241504696

   `main` passed!  https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/9176/    backporting now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17357 Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2573:
URL: https://github.com/apache/solr/pull/2573#issuecomment-2241236390

   Going to merge, let jenkins run for main, then back port...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] SOLR-17357 Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #2573:
URL: https://github.com/apache/solr/pull/2573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org