You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/19 15:11:03 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #6944: Keep PostgreSQL CURRENT_USER password unchanged (#6943)
sandynz opened a new pull request #6944:
URL: https://github.com/apache/shardingsphere/pull/6944
Fixes #6943.
Changes proposed in this pull request:
- Keep PostgreSQL CURRENT_USER password unchanged when running DCL integration test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #6944: Keep PostgreSQL CURRENT_USER password unchanged (#6943)
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6944:
URL: https://github.com/apache/shardingsphere/pull/6944#issuecomment-676507650
## Pull Request Test Coverage Report for [Build 13921](https://coveralls.io/builds/32862995)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **60.301%**
---
| Totals | [](https://coveralls.io/builds/32862995) |
| :-- | --: |
| Change from base [Build 13918](https://coveralls.io/builds/32856926): | 0.0% |
| Covered Lines: | 13713 |
| Relevant Lines: | 22741 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6944: Keep PostgreSQL CURRENT_USER password unchanged (#6943)
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6944:
URL: https://github.com/apache/shardingsphere/pull/6944#discussion_r473870614
##########
File path: shardingsphere-integration-test/shardingsphere-test-suite/src/test/resources/integrate/cases/dcl/dcl-integrate-test-cases.xml
##########
@@ -41,7 +41,6 @@
<dcl-test-case sql="ALTER USER user_dev WITH PASSWORD 'passwd_dev'" db-types="PostgreSQL"/>
<dcl-test-case sql="ALTER USER user_dev WITH PASSWORD 'passwd_dev'" db-types="PostgreSQL"/>
<dcl-test-case sql="ALTER ROLE role_dev_bak DROP MEMBER member1" db-types="SQLServer"/>
- <dcl-test-case sql="ALTER USER CURRENT_USER WITH ENCRYPTED PASSWORD 'password'" db-types="PostgreSQL"/>
Review comment:
Hi thanks for your clarification at #6943.
Got it. I think MySQL TESTS have the same issue as well. My suggestions are,
First, could you look at how MySQL tests deal with this issue in the same test-case file?
Second, do you think it is better to test the relevant SQL case with another new user or role?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 merged pull request #6944: Keep PostgreSQL CURRENT_USER password unchanged (#6943)
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #6944:
URL: https://github.com/apache/shardingsphere/pull/6944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org