You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/01 20:53:01 UTC
[GitHub] mbaijal opened a new issue #8913: MXNet 1.0.0 Release Feedback: Source Headers and License Files
mbaijal opened a new issue #8913: MXNet 1.0.0 Release Feedback: Source Headers and License Files
URL: https://github.com/apache/incubator-mxnet/issues/8913
## Description
This issue is to track the comments from the MXNet 1.0.0 [general vote thread - email](https://mail-archives.apache.org/mod_mbox/incubator-general/201712.mbox/browser)
The comments mentioned are as follows -
- **Issue 1:** LICENSE has a number of minor issues
- **Issue 2:** this file has an ASF header looks to be BSD licensed. [1] Other files that are licensed in similar confusing ways include [2][3][4][14]
- **Issue 3:** same with with MIT licensed files. [9][18][19]
- **Issue 4:** this file is BSD licensed [5] so would need to be added to LICENSE. As are a dozen files here [6] and this file [13, and this one [14] and 6 files here [15] and this one [16] and also this one [23]
- **Issue 5:** some file are still missing headers. For instance [7] and probable more.
- **Issue 6:** This file is listed at Apache 2.0 licensed in the LICNSE but is actually MIT licensed. [8] As I think is this [10] and these [17][20] (or it should be mentioned in license)
- **Issue 7:** This file has two apache headers [22]
- **Issue 8:** Also there one outstanding question from the last release how is this file licensed? (if you follow the URL mentioned in the file it is unclear). [24] but it unclear of the code come form that site or was written for the project by the author of that site.
```
**How to Fix**
1. Run Apache RAT and fix all issues that come up
2. Fix other issues mentioned above
3. Must be reviewed by Mentors
```
MXNet commit hash:
25720d0e3c29232a37e2650f3ba3a2454f9367bb
```
Index of files mentioned above -
1. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/prepare_mkl.sh
2. apache-mxnet-src-1.0.0.rc1-incubating/src/operator/nn/im2col.h / im2col.c
3. apache-mxnet-src-1.0.0.rc1-incubating/src/operator/contrib/nn/deformable_im2col.h / deformable_im2col.c
4. apache-mxnet-src-1.0.0.rc1-incubating/src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpuenums.h
5. apache-mxnet-src-1.0.0.rc1-incubating/src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpudevice.cuh
6. apache-mxnet-src-1.0.0.rc1-incubating/src/operator/contrib/ctc_include/contrib/moderngpu/include/device/
7. apache-mxnet-src-1.0.0.rc1-incubating/perl-package/AI-NNVMCAPI/Makefile.PL
8. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/nnvm/tvm/HalideIR/LICENSE
9. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/setup.py
10. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/gpu_nms.pyx
11. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/cpu_nms.pyx
12. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/bbox.pyx
13. apache-mxnet-src-1.0.0.rc1-incubating/nnvm/tvm/dmlc-core/cmake/Modules/FindCrypto.cmake
14. apache-mxnet-src-1.0.0.rc1-incubating/example/ssd/dataset/pycocotools/coco.py
15. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/pycocotools
16. apache-mxnet-src-1.0.0.rc1-incubating/dmlc-core/cmake/Modules/FindCrypto.cmake
17. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/gpu_nms.pyx
18. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/nms_kernel.cu
19. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/setup.py
20. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/cpu_nms.pyx
21. apache-mxnet-src-1.0.0.rc1-incubating/example/rcnn/rcnn/cython/bbox.pyx
22. apache-mxnet-src-1.0.0.rc1-incubating/tools/license_header.py
23. apache-mxnet-src-1.0.0.rc1-incubating.tar/apache-mxnet-src-1.0.0.rc1-incubating/cub/experimental/spmv_compare.cu
24. ./apache-mxnet-src-1.0.0.rc1-incubating/example/image-classification/predict-cpp/image-classification-predict.cc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services