You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/20 02:06:19 UTC
[GitHub] [inlong] EMsnap commented on a diff in pull request #5134: [INLONG-5117][SortStandalone] Support specify component type from remote config
EMsnap commented on code in PR #5134:
URL: https://github.com/apache/inlong/pull/5134#discussion_r925094732
##########
inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/utils/FlumeConfigGenerator.java:
##########
@@ -32,17 +33,19 @@ public class FlumeConfigGenerator {
public static final String KEY_SORT_CHANNEL_TYPE = "sortChannel.type";
public static final String KEY_SORT_SINK_TYPE = "sortSink.type";
public static final String KEY_SORT_SOURCE_TYPE = "sortSource.type";
+ public static final String KEY_SDK_START_TIME = "start-time";
Review Comment:
CamelCase please
##########
inlong-sort-standalone/sort-standalone-common/src/main/java/org/apache/inlong/sort/standalone/utils/FlumeConfigGenerator.java:
##########
@@ -51,14 +54,15 @@ public static Map<String, String> generateFlumeConfiguration(SortTaskConfig task
*
* @param flumeConf
*/
- private static void appendChannels(Map<String, String> flumeConf, String name) {
+ private static void appendChannels(Map<String, String> flumeConf, String name, Map<String, String> sinkParams) {
StringBuilder builder = new StringBuilder();
String channelName = name + "Channel";
flumeConf.put(name + ".channels", channelName);
String prefix = builder.append(name).append(".channels.").append(channelName).append(".").toString();
builder.setLength(0);
String channelType = builder.append(prefix).append("type").toString();
- String channelClass = CommonPropertiesHolder.getString(KEY_SORT_CHANNEL_TYPE);
+ String channelClass = sinkParams.getOrDefault(KEY_SORT_CHANNEL_TYPE,
Review Comment:
final a variable inside a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org