You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/12 11:33:43 UTC
[GitHub] [echarts] pissang commented on a change in pull request #15869: fix(tooltip): format boolean in value #15809
pissang commented on a change in pull request #15869:
URL: https://github.com/apache/echarts/pull/15869#discussion_r727043271
##########
File path: src/util/format.ts
##########
@@ -111,6 +111,9 @@ export function makeValueReadable(
? (isNumberUserReadable(value) ? value + '' : '-')
: '-';
}
+ if (typeof value === 'boolean') {
+ return value ? 'true' : 'false';
Review comment:
Also, this branch can be merged in the last return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org