[GitHub] [cordova-android] erisu edited a comment on issue #849: Fix: Cordova requirements consider the android-targetSdkVersion

[GitBox <gi...@apache.org>]

erisu edited a comment on issue #849: Fix: Cordova requirements consider the android-targetSdkVersion
URL: https://github.com/apache/cordova-android/pull/849#issuecomment-553232648
 
 
   I just re-ran the test case and I get the same results.... Can you provide your steps?
   
   **My Steps**
   
   ```
   $ npm un -g cordova
   removed 455 packages in 1.969s
   
   $ npm i -g cordova
   ..
   + cordova@9.0.0
   added 455 packages from 361 contributors in 14.819s
   
   $ cordova create androidTest com.foobar.androidTest androidTest && $_
   Creating a new cordova project.
   
   $ cordova platform add android
   Using cordova-fetch for cordova-android@^8.0.0
   Adding android project...
   Creating Cordova project for the Android platform:
   	Path: platforms/android
   	Package: com.foobar.androidTest
   	Name: androidTest
   	Activity: MainActivity
   	Android target: android-28
   Subproject Path: CordovaLib
   Subproject Path: app
   Android project created with cordova-android@8.1.0
   Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
   Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
   Installing "cordova-plugin-whitelist" for android
   Adding cordova-plugin-whitelist to package.json
   
   $ cordova build android -- --targetSdkVersion=20
   ...
   BUILD SUCCESSFUL in 11s
   44 actionable tasks: 44 executed
   Built the following apk(s):
   	/private/tmp/cordova-test/androidTest/platforms/android/app/build/outputs/apk/debug/app-debug.apk
   
   $ aapt dump badging platforms/android/app/build/outputs/apk/debug/app-debug.apk
   
   package: name='com.foobar.androidTest' versionCode='10000' versionName='1.0.0' platformBuildVersionName='1.0.0' compileSdkVersion='28' compileSdkVersionCodename='9'
   sdkVersion:'19'
   targetSdkVersion:'20'
   ....
   ```
   
   `targetSdkVersion` version is set to `20`.
   
   Additional notes: I tested with the `aapt` from `build-tools@29.0.0` and `build-tools@28.0.3`
   
   I guess we talking about the display of `cordova requirements android` does not represent what was built?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org