You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Glen Mazza (JIRA)" <ji...@apache.org> on 2011/07/21 01:59:59 UTC
[jira] [Created] (KARAF-753) commandlist --help points to help for
jaas:pending
commandlist --help points to help for jaas:pending
--------------------------------------------------
Key: KARAF-753
URL: https://issues.apache.org/jira/browse/KARAF-753
Project: Karaf
Issue Type: Bug
Affects Versions: 2.2.2
Reporter: Glen Mazza
Priority: Minor
Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
karaf@root> commandlist --help
DESCRIPTION
jaas:pending
Lists the modification on the active realm/module.
SYNTAX
jaas:pending [options]
OPTIONS
--help
Display this help message
karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070743#comment-13070743 ]
Jean-Baptiste Onofré commented on KARAF-753:
--------------------------------------------
It makes sense Glen.
Just for explanation, in the blueprint descriptor, we have:
<command name="jaas/commandlist">
<action class="org.apache.karaf.jaas.command.ListPendingCommand"/>
</command>
So we can see the command name (jaas/commandlist) linked to the ListPendingCommand bean.
That's why we have a mix between the command name and the real command :)
I'm agree with your plan, I will do it in this way.
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070723#comment-13070723 ]
Jean-Baptiste Onofré commented on KARAF-753:
--------------------------------------------
It's "normal".
The listcommand (defined in blueprint) correspond to the ListPendingCommand.
That's why "listcommand --help" displays the ListPendingCommand help.
I propose:
1/ to rename listcommand to jaas:pending (which should be the case)
2/ for backward compatibility, I propose to add an alias listcommand to jaas:pending
WDYT ?
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-753) commandlist --help points to help for
jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-753:
---------------------------------------
Fix Version/s: 2.2.3
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-753) commandlist --help points to help for
jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-753:
---------------------------------------
Component/s: karaf-shell
Fix Version/s: 3.0.0
Assignee: Jean-Baptiste Onofré
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070738#comment-13070738 ]
Glen Mazza commented on KARAF-753:
----------------------------------
I'm confused--first, I think you mean "commandlist" and not "listcommand". Secondly, I'm confused why OSGi Blueprint dependency injection would define anything concerning the jaas:pending command (the Blueprint schema: http://www.osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd includes nothing with the phrase "command" or "pending".)
My general recommendation, would be yes, to name the method whatever it should be named in the 2.x series, adding an alias if necessary but to *not* include the alias in the 3.0 series (if the only reason why you would do so is for backward compatibility). Because major version upgrades are where you get rid of old commands/APIs.
But whatever you do, when I enter karaf> {command} --help, when I see the help for it, I should see that same {command} in the DESCRIPTION field of the help text. The present commandlist in one and jaas:pending in the other looks like a strange bug to most users.
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-753) commandlist --help points to help for
jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved KARAF-753.
----------------------------------------
Resolution: Fixed
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092683#comment-13092683 ]
Jean-Baptiste Onofré commented on KARAF-753:
--------------------------------------------
Fixed on trunk: revision 1162670.
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-753) commandlist --help points to help for
jaas:pending
Posted by "Jamie goodyear (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-753.
--------------------------------
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092686#comment-13092686 ]
Jean-Baptiste Onofré commented on KARAF-753:
--------------------------------------------
Fixed on karaf-2.2.x: revision 1162672.
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-753) commandlist --help points to help
for jaas:pending
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-753 started by Jean-Baptiste Onofré.
> commandlist --help points to help for jaas:pending
> --------------------------------------------------
>
> Key: KARAF-753
> URL: https://issues.apache.org/jira/browse/KARAF-753
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.2
> Reporter: Glen Mazza
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.3, 3.0.0
>
>
> Not sure why (can't find the problem in the source code), but commandlist --help is pointing to another command:
> karaf@root> commandlist --help
> DESCRIPTION
> jaas:pending
> Lists the modification on the active realm/module.
> SYNTAX
> jaas:pending [options]
> OPTIONS
> --help
> Display this help message
> karaf@root>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira