You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2021/12/18 20:18:02 UTC

[lucene] branch main updated: LUCENE-10308: sort input files for ecj so that module-info.java comes first.

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/main by this push:
     new 2a44ff5  LUCENE-10308: sort input files for ecj so that module-info.java comes first.
2a44ff5 is described below

commit 2a44ff532ee715349523355eda97bd1ed589d11f
Author: Dawid Weiss <da...@carrotsearch.com>
AuthorDate: Sat Dec 18 21:17:56 2021 +0100

    LUCENE-10308: sort input files for ecj so that module-info.java comes first.
---
 gradle/validation/ecj-lint.gradle | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gradle/validation/ecj-lint.gradle b/gradle/validation/ecj-lint.gradle
index 4ad97fc..591eb84 100644
--- a/gradle/validation/ecj-lint.gradle
+++ b/gradle/validation/ecj-lint.gradle
@@ -73,6 +73,10 @@ allprojects {
             srcDirs.collectMany { dir ->
               project.fileTree(dir: dir, include: "**/*.java" ).files
             }
+            // Try to sort all input files; a side-effect of this should be that module-info.java
+            // is placed first on the list, which works around ECJ bug:
+            // https://bugs.eclipse.org/bugs/show_bug.cgi?id=569833
+            .sort()
             .collect {file -> escapeFileName(file.absolutePath.toString())}.join("\n"), "UTF-8")
 
         args += [ "-d", "none" ]