[GitHub] milleruntime commented on a change in pull request #793: Cleanup TabletServerLogger

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #793: Cleanup TabletServerLogger
URL: https://github.com/apache/accumulo/pull/793#discussion_r240838610
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##########
 @@ -1065,9 +1071,13 @@ private void flush(UpdateSession us) {
                 // only log and commit mutations if there were some
                 // that did not violate constraints... this is what
                 // prepareMutationsForCommit() expects
-                sendables.put(e.getCommitSession(),
-                    new Mutations(DurabilityImpl.resolveDurabilty(us.durability, tabletDurability),
-                        e.getNonViolators()));
+                CommitSession cs = e.getCommitSession();
 
 Review comment:
   Yeah I wasn't completely sure what that code is doing but that sounds good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services