[GitHub] [helix] NealSun96 commented on a change in pull request #1701: Improve WAGED simulation API by throwing exception on FAILED_TO_CALCULATE

[GitBox <gi...@apache.org>]

NealSun96 commented on a change in pull request #1701:
URL: https://github.com/apache/helix/pull/1701#discussion_r617784196



##########
File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/ReadOnlyWagedRebalancer.java
##########
@@ -48,6 +50,14 @@ public ReadOnlyWagedRebalancer(String metadataStoreAddress, String clusterName,
         ConstraintBasedAlgorithmFactory.getInstance(preferences), Optional.empty());
   }
 
+  @Override
+  protected List<HelixRebalanceException.Type> failureTypesToPropagate() {
+    // Also propagate FAILED_TO_CALCULATE for ReadOnlyWagedRebalancer
+    return Arrays.asList(HelixRebalanceException.Type.INVALID_REBALANCER_STATUS,

Review comment:
       I don't think that's better because ReadOnlyWagedRebalancer doesn't always propagate a superset of failure types; that might change in the future. Separate lists are clearer. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org