You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by John Casey <jd...@commonjava.org> on 2003/04/01 18:10:25 UTC

[PATCH] fix for proper inhertance of 'default' property settings when using reactor

I have applied this patch to my local copy of maven to allow the correct
inheritance rules for properties supplied by the parent project to flow
to the child during a reactor build, instead of overwriting them with
the defaults from driver.properties.  This allows me to specify things
like 'maven.username' at the parent project.properties level, and it
will propagate to the children for use in jar:deploy.  Previously, when
reactor spawned the child context, it would impose the default value of
USERNAME_NOT_SET to 'maven.username' thus making it impossible to take
advantage of the hierarchical nature of a reactor build for common
property values.  This patch corrects that problem by adding another
file: 'defaults.properties' which is loaded AFTER inheritance is turned
back on, so as to avoid overwriting values specified at the parent
project level.  MavenUtils.java and MavenConstants.java, along with
driver.properties and project.xml have been adjusted to accommodate this
change. Defaults.properties lives in src/conf, just like
'driver.properties.'


Enjoy
-- 
John Casey <jd...@commonjava.org>

Re: [PATCH] fix for proper inhertance of 'default' property settings when using reactor

Posted by John Casey <jd...@commonjava.org>.
Refer to MAVEN-294 in Jira for more info and touchstone test case.

On Tue, 2003-04-01 at 10:10, John Casey wrote:
> I have applied this patch to my local copy of maven to allow the correct
> inheritance rules for properties supplied by the parent project to flow
> to the child during a reactor build, instead of overwriting them with
> the defaults from driver.properties.  This allows me to specify things
> like 'maven.username' at the parent project.properties level, and it
> will propagate to the children for use in jar:deploy.  Previously, when
> reactor spawned the child context, it would impose the default value of
> USERNAME_NOT_SET to 'maven.username' thus making it impossible to take
> advantage of the hierarchical nature of a reactor build for common
> property values.  This patch corrects that problem by adding another
> file: 'defaults.properties' which is loaded AFTER inheritance is turned
> back on, so as to avoid overwriting values specified at the parent
> project level.  MavenUtils.java and MavenConstants.java, along with
> driver.properties and project.xml have been adjusted to accommodate this
> change. Defaults.properties lives in src/conf, just like
> 'driver.properties.'
> 
> 
> Enjoy
-- 
John Casey <jd...@commonjava.org>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org