[jira] [Commented] (STORM-1038) Upgrade netty transport from 3.x to 4.x

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089771#comment-15089771 ] 

ASF GitHub Bot commented on STORM-1038:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/728#discussion_r49227072
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/ISaslClient.java ---
    @@ -17,11 +17,9 @@
      */
     package backtype.storm.messaging.netty;
     
    -import org.jboss.netty.channel.Channel;
    -import backtype.storm.Config;
    -
     public interface ISaslClient {
    -    void channelConnected(Channel channel);
    +
    +    // void channelConnected(Channel channel);
    --- End diff --
    
    If this is not needed we should remove it, not comment it out.


> Upgrade netty transport from 3.x to 4.x
> ---------------------------------------
>
>                 Key: STORM-1038
>                 URL: https://issues.apache.org/jira/browse/STORM-1038
>             Project: Apache Storm
>          Issue Type: Dependency upgrade
>          Components: storm-core
>            Reporter: Hang Sun
>            Priority: Minor
>              Labels: performance
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> It will be nice to upgrade netty to 4.x to take advantage of its more efficient memory usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)