You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/09 06:59:04 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Alonexc opened a new issue, #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/catalog/EventMeshCatalogClient.java line 76
analysis and explanation:
This line is in the form of
String str = str.equals("someOtherString");
A NullPointerException may occur if the String variable str is null. If instead the code was restructured to
String str = someOtherString".equals(str);
that is, call equals() n the string literal, passing the variable as an argument, then this exception could never happen as both equals() check for null.
### Describe the solution you'd like
reference:
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345276278
> Hello there, anyone working on this issue currently @Alonexc and @xwm1992 ?
@rukundob451 No one has claimed it yet, do you want to try? If you want to work for this, you can submit a pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345463934
> Yes @Alonexc wanted to give it a try.
@rukundob451 Welcome, you can submit a pr first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1367671586
> 这个问题可以贡献吗？
This issue has been fixed and I will close it, are you interested in other issues? There are many such issues in the community, so feel free to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] rukundob451 commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
rukundob451 commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1367790473
> @vasaniyakush This issue has been fixed and I will close it, are you interested in other issues? There are many such issues in the community, so feel free to contribute.
Sure @Alonexc will check them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] rukundob451 commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
rukundob451 commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345337503
> > Hello there, anyone working on this issue currently @Alonexc and @xwm1992 ?
>
> @rukundob451 No one has claimed it yet, do you want to try? If you want to work for this, you can submit a pr.
Yes @Alonexc wanted to give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] rukundob451 commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
rukundob451 commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345557156
> > Yes @Alonexc wanted to give it a try.
>
> @rukundob451 Welcome, you can submit a pr first.
Alright sure, working on it.
Any possible ideas you think I would use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] rukundob451 commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
rukundob451 commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345161028
Hello there, anyone working on this issue currently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vasaniyakush commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
vasaniyakush commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1367145876
Is this issue available for contribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc closed issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
Alonexc closed issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
URL: https://github.com/apache/incubator-eventmesh/issues/2544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #2544: [Enhancement] Method makes literal string comparisons passing the literal as an argument
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #2544:
URL: https://github.com/apache/incubator-eventmesh/issues/2544#issuecomment-1345755452
> > > Yes @Alonexc wanted to give it a try.
> >
> >
> > @rukundob451 Welcome, you can submit a pr first.
>
> Alright sure, working on it. Any possible ideas you think I would use?
@rukundob451 This is just a small issue, just follow the reference and fix it, if you have a better idea is also possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org