You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/30 13:54:50 UTC
[GitHub] [incubator-iotdb] SailVR opened a new pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
SailVR opened a new pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR commented on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR commented on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738
> > Good job.
> > However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.
>
> When the limit is larger than fetchSize, we press fetchSize several times in the background. Let me add one test when limit>fetchSize
IoTDBSimpleQueryIT.testShowTimeseriesDataSet4()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR edited a comment on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR edited a comment on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738
> > Good job.
> > However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.
>
> When the limit is larger than fetchSize, we press fetchSize several times in the background. Let me add one test when limit>fetchSize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR edited a comment on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR edited a comment on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738
> > Good job.
> > However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.
>
> We will consider it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR removed a comment on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR removed a comment on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152321
> Good job.
>
> However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.
When the limit is larger than fetchSize, we press fetchSize several times in the background. Let me add one test when limit>fetchSize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR commented on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR commented on pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152321
> Good job.
>
> However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.
When the limit is larger than fetchSize, we press fetchSize several times in the background. Let me add one test when limit>fetchSize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SailVR closed pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
Posted by GitBox <gi...@apache.org>.
SailVR closed pull request #1443:
URL: https://github.com/apache/incubator-iotdb/pull/1443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org