You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "everfid-ever (via GitHub)" <gi...@apache.org> on 2025/12/06 12:17:51 UTC

[PR] fix: support RM delete undo log request [incubator-seata-go]

everfid-ever opened a new pull request, #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023

   Fixes #1016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-4096780762

   > Plz fix the CI problems.
   
   I reopen a new PR, plz check the new one, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677751662

   > Why is the issue link gone?
   
   The account that submitted the issue has been deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "LucienShen-Liu (via GitHub)" <gi...@apache.org>.
LucienShen-Liu commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3690800708

   > > Plz fix the ci
   > 
   > Could you please help me check the integration test code? Thanks :)
   
   There's currently an issue with the integration test; it should pass once we fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "thunguo (via GitHub)" <gi...@apache.org>.
thunguo commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3976764085

   Plz fix the CI problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever closed pull request #1023: fix: support RM delete undo log request
URL: https://github.com/apache/incubator-seata-go/pull/1023


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever closed pull request #1023: fix: support RM delete undo log request
URL: https://github.com/apache/incubator-seata-go/pull/1023


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677771276

   > > > Why is the issue link gone?
   > > 
   > > 
   > > The account that submitted the issue has been deleted.
   > 
   > Could you please add an issue or explain in detail in the PR what functions have been implemented
   
   already added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677753214

   > > Why is the issue link gone?
   > 
   > The account that submitted the issue has been deleted.
   
   Could you please add an issue or explain in detail in the PR what functions have been implemented


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3620087083

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1023?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 62.72%. Comparing base ([`774046b`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/774046b21a81259e56b8d2825276276e94a410fa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`53934b6`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/53934b6b577ec7812ea75668a5a751c911151870?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1023      +/-   ##
   ==========================================
   + Coverage   61.67%   62.72%   +1.04%     
   ==========================================
     Files         213      215       +2     
     Lines       13059    13086      +27     
   ==========================================
   + Hits         8054     8208     +154     
   + Misses       4481     4351     -130     
   - Partials      524      527       +3     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1023?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "LucienShen-Liu (via GitHub)" <gi...@apache.org>.
LucienShen-Liu commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3678455873

   > > 请修复词
   > 
   > 请问您能帮我检查一下集成测试代码吗?谢谢:)
   
   The job failed due to a panic in samples/integrate_test/at/insert_on_update/main.go at line 62, with the message: panic: failed. This occurred during integration testing, as called by the Makefile, and was detected by the integrate-test workflow.
   
   Solution steps:
   
   Review main.go at line 62 to determine why the panic("failed") is triggered. Typically, this line panics when a critical check or operation fails (e.g., DB operation, transaction, assertion, or error check).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677752260

   > Why is the issue link gone?
   
   The issue was raised by Guo Tun, and the account was taken private, so the issue disappeared.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677791254

   Plz fix the ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "flypiggyyoyoyo (via GitHub)" <gi...@apache.org>.
flypiggyyoyoyo commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677792276

   @flypiggyyoyoyo cr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] fix: support RM delete undo log request [incubator-seata-go]

Posted by "everfid-ever (via GitHub)" <gi...@apache.org>.
everfid-ever commented on PR #1023:
URL: https://github.com/apache/incubator-seata-go/pull/1023#issuecomment-3677899368

   > Plz fix the ci
   
   Could you please help me check the integration test code? Thanks :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org