You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/02/06 16:12:50 UTC
[PR] [DRAFT][Iceberg 1.11] View registration [polaris]
adutra opened a new pull request, #3689:
URL: https://github.com/apache/polaris/pull/3689
Requires #3687
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3871937366
> Wonder whether we should focus on the necessary changes in the feature branch. Register-view is a new functionality, wonder whether we should do this change directly against main once the feature branch is merged. WDYT?
I think it would be nicer, if possible, to start working ahead of phase.
Register view is just one of the items we need to work on. There is also "register table with overwrite", cf. #3682. And then, of course, there is remote signing, if the spec changes get merged before 1.11 is cut.
But I get the problem with merging new features into the `feature/iceberg-1.11` branch: the individual commits would end up squashed when merged to `main`, which is not great.
Wdyt about enabling "Rebase & Merge" so that we could keep working on the feature branch, then rebase the final result onto `main`, keeping each new feature in a separate commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3872723107
I think we can keep those things as separate commits (rebase/squash as needed) on the feature branch and then "peal out" individual PRs from the feature branch. That makes reviewing the "final PRs" easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3872676532
I think we can keep those things as separate commits (rebase/squash as needed) on the feature branch and then "peal out" individual PRs from the feature branch. That makes reviewing the "final PRs" easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3880490913
This is now ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3871942504
The other option is to keep working against the feature branch, but refraining from merging new features into it, and wait instead until `main` is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3881333580
I might have missed the discussion about the plan for merging this feature branch to `main`, but it makes sense to me to merge individual PRs into the feature branch as work progresses.
If we want to redo those PRs against `main` later, that would be fine too from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3896808848
> It seems the change is missing a "location overlap" check to prevent that any table/view share the the same "directory tree", which would lead to data security issues (vending credentials granting access to other tables/views).
This validation is already done in `BasePolarisViewOperations.doCommit()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3872687168
I think we can keep those things as separate commits (rebase/squash as needed) on the feature branch and then "peal out" individual PRs from the feature branch. That makes reviewing the "final PRs" easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT][Iceberg 1.11] View registration [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-3872677645
I think we can keep those things as separate commits (rebase/squash as needed) on the feature branch and then "peal out" individual PRs from the feature branch. That makes reviewing the "final PRs" easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-4006507914
Rebased to fix conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3689:
URL: https://github.com/apache/polaris/pull/3689#issuecomment-4053634348
I think this PR has waited long enough. If there are no concerns, I am going to merge this on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Iceberg 1.11] View registration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #3689:
URL: https://github.com/apache/polaris/pull/3689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org